From: fengchengwen <fengchengwen@huawei.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>,
x86@kernel.org, liuyonglong@huawei.com,
"Rafael J . Wysocki" <rafael@kernel.org>,
Kees Cook <kees@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Sohil Mehta <sohil.mehta@intel.com>,
Kai Huang <kai.huang@intel.com>,
Kevin Loughlin <kevinloughlin@google.com>,
"H . Peter Anvin" <hpa@zytor.com>,
Ilkka Koskinen <ilkka@os.amperecomputing.com>,
WANG Xuerui <kernel@xen0n.name>, Will Deacon <will@kernel.org>,
Thorsten Blum <thorsten.blum@linux.dev>,
linux-acpi@vger.kernel.org, Alexandre Ghiti <alex@ghiti.fr>,
Jonathan Corbet <corbet@lwn.net>,
Huacai Chen <chenhuacai@kernel.org>,
linux-riscv@lists.infradead.org,
Peter Zijlstra <peterz@infradead.org>,
Pawan Gupta <pawan.kumar.gupta@linux.intel.com>,
Yanteng Si <si.yanteng@linux.dev>,
linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org,
Zheyun Shen <szy0127@sjtu.edu.cn>, Len Brown <lenb@kernel.org>,
Tom Lendacky <thomas.lendacky@amd.com>,
Thomas Huth <thuth@redhat.com>, Albert Ou <aou@eecs.berkeley.edu>,
"Ahmed S . Darwish" <darwi@linutronix.de>,
Ma Ke <make24@iscas.ac.cn>, James Clark <james.clark@linaro.org>,
Wei Huang <wei.huang2@amd.com>,
Besar Wicaksono <bwicaksono@nvidia.com>,
Borislav Petkov <bp@alien8.de>,
loongarch@lists.linux.dev, Shuah Khan <skhan@linuxfoundation.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Xin Li <xin@zytor.com>,
Andy Gospodarek <andrew.gospodarek@broadcom.com>,
Ingo Molnar <mingo@redhat.com>,
wanghuiqiang@huawei.com, Juergen Gross <jgross@suse.com>,
Sean Christopherson <seanjc@google.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, linux-perf-users@vger.kernel.org,
wangzhou1@hisilicon.com, Palmer Dabbelt <palmer@dabbelt.com>,
Thomas Gleixner <tglx@kernel.org>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Paul Walmsley <pjw@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 1/2] ACPI: Rename get_acpi_id_for_cpu() to acpi_get_cpu_acpi_id() on non-x86
Date: Wed, 11 Mar 2026 10:57:49 +0800 [thread overview]
Message-ID: <f2bf1055-ae5f-44bb-9bd4-8888099933fb@huawei.com> (raw)
In-Reply-To: <20260310175305.GA730372@bhelgaas>
On 3/11/2026 1:53 AM, Bjorn Helgaas wrote:
> On Tue, Mar 10, 2026 at 11:20:48AM +0800, Chengwen Feng wrote:
>> To unify the CPU ACPI ID retrieval interface across architectures,
>> rename the existing get_acpi_id_for_cpu() function to
>> acpi_get_cpu_acpi_id() on arm64/riscv/loongarch platforms.
>>
>> This is a pure rename with no functional change, preparing for a
>> consistent ACPI Processor UID retrieval interface across all ACPI-enabled
>> platforms.
>
> Really a question for the ACPI folks, but my preferences would be:
>
> - Simpler name for the interface, e.g., "acpi_get_cpu_id()"
OK, and how about add u-, like: acpi_get_cpu_uid()
>
> - Single prototype in generic header, e.g., include/linux/acpi.h
OK
>
> - Split the x86 part to a separate patch and maybe (a tangent, but
> looks dubious to me) figure out whether/why xen needs xen_vcpu_id
> to be ACPI CPU IDs
OK for a separate patch for x86.
Btw: the x86 implementation in 2/2 commit may has problem, please see the reply in 2/2 for detail.
>
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
>> Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
>> ---
>> arch/arm64/include/asm/acpi.h | 4 ++--
>> arch/loongarch/include/asm/acpi.h | 2 +-
>> arch/riscv/include/asm/acpi.h | 2 +-
>> arch/riscv/kernel/acpi_numa.c | 2 +-
>> drivers/acpi/pptt.c | 16 ++++++++--------
>> drivers/acpi/riscv/rhct.c | 2 +-
>> drivers/perf/arm_cspmu/arm_cspmu.c | 2 +-
>> 7 files changed, 15 insertions(+), 15 deletions(-)
>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2026-03-11 2:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 3:20 [PATCH v5 0/2] Fix get cpu steer-tag fail on ARM64 platform Chengwen Feng
2026-03-10 3:20 ` [PATCH v5 1/2] ACPI: Rename get_acpi_id_for_cpu() to acpi_get_cpu_acpi_id() on non-x86 Chengwen Feng
2026-03-10 17:53 ` Bjorn Helgaas
2026-03-10 22:39 ` Andrew Cooper
2026-03-11 2:57 ` fengchengwen [this message]
2026-03-10 3:20 ` [PATCH v5 2/2] PCI/TPH: Fix get cpu steer-tag fail on ARM64 platform Chengwen Feng
2026-03-10 15:58 ` Jeremy Linton
2026-03-10 22:09 ` Bjorn Helgaas
2026-03-11 3:00 ` fengchengwen
2026-03-11 17:02 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2bf1055-ae5f-44bb-9bd4-8888099933fb@huawei.com \
--to=fengchengwen@huawei.com \
--cc=ajit.khaparde@broadcom.com \
--cc=alex@ghiti.fr \
--cc=andrew.gospodarek@broadcom.com \
--cc=aou@eecs.berkeley.edu \
--cc=bhelgaas@google.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=bwicaksono@nvidia.com \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=corbet@lwn.net \
--cc=darwi@linutronix.de \
--cc=dave.hansen@linux.intel.com \
--cc=helgaas@kernel.org \
--cc=hpa@zytor.com \
--cc=ilkka@os.amperecomputing.com \
--cc=james.clark@linaro.org \
--cc=jgross@suse.com \
--cc=jonathan.cameron@huawei.com \
--cc=kai.huang@intel.com \
--cc=kees@kernel.org \
--cc=kernel@xen0n.name \
--cc=kevinloughlin@google.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=liuyonglong@huawei.com \
--cc=loongarch@lists.linux.dev \
--cc=make24@iscas.ac.cn \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=palmer@dabbelt.com \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=peterz@infradead.org \
--cc=pjw@kernel.org \
--cc=rafael@kernel.org \
--cc=robin.murphy@arm.com \
--cc=seanjc@google.com \
--cc=si.yanteng@linux.dev \
--cc=skhan@linuxfoundation.org \
--cc=sohil.mehta@intel.com \
--cc=somnath.kotur@broadcom.com \
--cc=stable@vger.kernel.org \
--cc=szy0127@sjtu.edu.cn \
--cc=tglx@kernel.org \
--cc=thomas.lendacky@amd.com \
--cc=thorsten.blum@linux.dev \
--cc=thuth@redhat.com \
--cc=wanghuiqiang@huawei.com \
--cc=wangzhou1@hisilicon.com \
--cc=wei.huang2@amd.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
--cc=xin@zytor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox