From: Damien Le Moal <dlemoal@kernel.org>
To: Wang Jianzheng <wangjianzheng@vivo.com>,
Linus Walleij <linus.walleij@linaro.org>,
"open list:CANAAN/KENDRYTE K210 SOC FPIOA DRIVER"
<linux-riscv@lists.infradead.org>,
"open list:CANAAN/KENDRYTE K210 SOC FPIOA DRIVER"
<linux-gpio@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Cc: opensource.kernel@vivo.com
Subject: Re: [PATCH 4/5] pinctrl: k210: Use devm_clk_get_enabled() helpers
Date: Fri, 30 Aug 2024 13:54:25 +0900 [thread overview]
Message-ID: <f4450d92-1cea-4051-8906-ace6cd4165a7@kernel.org> (raw)
In-Reply-To: <20240829064938.20114-1-wangjianzheng@vivo.com>
On 8/29/24 3:49 PM, Wang Jianzheng wrote:
> The devm_clk_get_enabled() helpers:
> - call devm_clk_get()
> - call clk_prepare_enable() and register what is needed in order to
> call clk_disable_unprepare() when needed, as a managed resource.
>
> This simplifies the code and avoids the calls to clk_disable_unprepare().
>
> Signed-off-by: Wang Jianzheng <wangjianzheng@vivo.com>
Looks OK to me.
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2024-08-30 4:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 6:49 [PATCH 4/5] pinctrl: k210: Use devm_clk_get_enabled() helpers Wang Jianzheng
2024-08-30 4:54 ` Damien Le Moal [this message]
2024-09-02 8:26 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4450d92-1cea-4051-8906-ace6cd4165a7@kernel.org \
--to=dlemoal@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=opensource.kernel@vivo.com \
--cc=wangjianzheng@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox