From: Alex Elder <elder@riscstar.com>
To: Philipp Zabel <p.zabel@pengutronix.de>,
mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org
Cc: dlan@gentoo.org, heylenay@4d2.org, guodong@riscstar.com,
paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, spacemit@lists.linux.dev,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 6/7] clk: spacemit: define new syscons with only resets
Date: Tue, 15 Apr 2025 07:01:50 -0500 [thread overview]
Message-ID: <f856f692-03c6-4064-bc7c-ad565fed6d2f@riscstar.com> (raw)
In-Reply-To: <eee41968ecb0c16da214819b9a43e9dd881fcf13.camel@pengutronix.de>
On 4/15/25 3:22 AM, Philipp Zabel wrote:
>> +static const struct ccu_reset_data apbc2_reset_data[] = {
>> + [RESET_APBC2_UART1] = RESET_DATA(APBC2_UART1_CLK_RST, BIT(2), (0)),
>> + [RESET_APBC2_SSP2] = RESET_DATA(APBC2_SSP2_CLK_RST, BIT(2), (0)),
>> + [RESET_APBC2_TWSI3] = RESET_DATA(APBC2_TWSI3_CLK_RST, BIT(2), (0)),
>> + [RESET_APBC2_RTC] = RESET_DATA(APBC2_RTC_CLK_RST, BIT(2), (0)),
>> + [RESET_APBC2_TIMERS0] = RESET_DATA(APBC2_TIMERS0_CLK_RST, BIT(2), (0)),
>> + [RESET_APBC2_KPC] = RESET_DATA(APBC2_KPC_CLK_RST, BIT(2), (0)),
>> + [RESET_APBC2_GPIO] = RESET_DATA(APBC2_GPIO_CLK_RST, BIT(2), (0)),
> Superfluous parentheses.
Wow, this is something I don't normally do. I had to check to see if
I managed to drop "BIT" or something (I did not). Anyway, I'll fix
this in the next revision. Thanks.
-Alex
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2025-04-15 12:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-14 19:17 [PATCH v4 0/7] clk: spacemit: add K1 reset support Alex Elder
2025-04-14 19:17 ` [PATCH v4 1/7] dt-bindings: soc: spacemit: define spacemit,k1-ccu resets Alex Elder
2025-04-14 19:17 ` [PATCH v4 2/7] clk: spacemit: rename spacemit_ccu_data fields Alex Elder
2025-04-15 4:18 ` Haylen Chu
2025-04-14 19:17 ` [PATCH v4 3/7] clk: spacemit: add reset controller support Alex Elder
2025-04-15 8:24 ` Philipp Zabel
2025-04-14 19:17 ` [PATCH v4 4/7] clk: spacemit: define existing syscon resets Alex Elder
2025-04-14 19:17 ` [PATCH v4 5/7] clk: spacemit: make clocks optional Alex Elder
2025-04-14 19:17 ` [PATCH v4 6/7] clk: spacemit: define new syscons with only resets Alex Elder
2025-04-15 8:22 ` Philipp Zabel
2025-04-15 11:33 ` Alex Elder
2025-04-15 12:01 ` Alex Elder [this message]
2025-04-14 19:17 ` [PATCH v4 7/7] riscv: dts: spacemit: add reset support for the K1 SoC Alex Elder
2025-04-29 20:56 ` [PATCH v4 0/7] clk: spacemit: add K1 reset support Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f856f692-03c6-4064-bc7c-ad565fed6d2f@riscstar.com \
--to=elder@riscstar.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=guodong@riscstar.com \
--cc=heylenay@4d2.org \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=spacemit@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox