From: Eduard Zingerman <eddyz87@gmail.com>
To: Pu Lehui <pulehui@huaweicloud.com>,
bpf@vger.kernel.org, linux-riscv@lists.infradead.org,
netdev@vger.kernel.org
Cc: "Andrii Nakryiko" <andrii@kernel.org>,
"Mykola Lysenko" <mykolal@fb.com>,
"Björn Töpel" <bjorn@kernel.org>,
"Puranjay Mohan" <puranjay@kernel.org>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Martin KaFai Lau" <martin.lau@linux.dev>,
"Song Liu" <song@kernel.org>,
"Yonghong Song" <yonghong.song@linux.dev>,
"John Fastabend" <john.fastabend@gmail.com>,
"KP Singh" <kpsingh@kernel.org>,
"Stanislav Fomichev" <sdf@fomichev.me>,
"Hao Luo" <haoluo@google.com>, "Jiri Olsa" <jolsa@kernel.org>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Pu Lehui" <pulehui@huawei.com>
Subject: Re: [PATCH bpf-next v2 03/10] selftests/bpf: Disable feature-llvm for vmtest
Date: Wed, 04 Sep 2024 12:37:33 -0700 [thread overview]
Message-ID: <fc9a03f1809cfdd80a9a8cb7b513e32302be5a43.camel@gmail.com> (raw)
In-Reply-To: <20240904141951.1139090-4-pulehui@huaweicloud.com>
On Wed, 2024-09-04 at 14:19 +0000, Pu Lehui wrote:
> From: Pu Lehui <pulehui@huawei.com>
>
> After commit b991fc520700 ("selftests/bpf: utility function to get
> program disassembly after jit"), Makefile will link libLLVM* related
> libraries to the user binary execution file when detecting that
> feature-llvm is enabled, which will cause the local vmtest to appear as
> follows mistake:
>
> ./test_progs: error while loading shared libraries: libLLVM-17.so.1:
> cannot open shared object file: No such file or directory
>
> Considering that the get_jited_program_text() function is a useful tool
> for user debugging and will not be relied upon by the entire bpf
> selftests, let's turn it off in local vmtest.
>
> Signed-off-by: Pu Lehui <pulehui@huawei.com>
> ---
I actually don't agree.
The __jited tag is supposed to be used by selftests
(granted, used by a single selftest for now).
Maybe add an option to forgo LLVM linkage when test_progs are compiled?
Regarding base image lacking libLLVM -- I need to fix this.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2024-09-04 19:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 14:19 [PATCH bpf-next v2 00/10] Local vmtest enhancement and RV64 enabled Pu Lehui
2024-09-04 14:19 ` [PATCH bpf-next v2 01/10] selftests/bpf: Adapt OUTPUT appending logic to lower versions of Make Pu Lehui
2024-09-04 18:49 ` Andrii Nakryiko
2024-09-04 19:29 ` Eduard Zingerman
2024-09-04 14:19 ` [PATCH bpf-next v2 02/10] selftests/bpf: Rename fallback in bpf_dctcp to avoid naming conflict Pu Lehui
2024-09-04 14:19 ` [PATCH bpf-next v2 03/10] selftests/bpf: Disable feature-llvm for vmtest Pu Lehui
2024-09-04 19:37 ` Eduard Zingerman [this message]
2024-09-04 23:08 ` Eduard Zingerman
2024-09-05 8:36 ` Pu Lehui
2024-09-04 14:19 ` [PATCH bpf-next v2 04/10] selftests/bpf: Limit URLS parsing logic to actual scope in vmtest Pu Lehui
2024-09-04 14:19 ` [PATCH bpf-next v2 05/10] selftests/bpf: Support local rootfs image for vmtest Pu Lehui
2024-09-04 21:40 ` Eduard Zingerman
2024-09-04 14:19 ` [PATCH bpf-next v2 06/10] selftests/bpf: Enable cross platform testing " Pu Lehui
2024-09-04 14:19 ` [PATCH bpf-next v2 07/10] selftests/bpf: Add config.riscv64 Pu Lehui
2024-09-04 14:19 ` [PATCH bpf-next v2 08/10] selftests/bpf: Add DENYLIST.riscv64 Pu Lehui
2024-09-04 14:19 ` [PATCH bpf-next v2 09/10] selftests/bpf: Add riscv64 configurations to local vmtest Pu Lehui
2024-09-04 14:19 ` [PATCH bpf-next v2 10/10] selftests/bpf: Add description for running vmtest on RV64 Pu Lehui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc9a03f1809cfdd80a9a8cb7b513e32302be5a43.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=martin.lau@linux.dev \
--cc=mykolal@fb.com \
--cc=netdev@vger.kernel.org \
--cc=palmer@dabbelt.com \
--cc=pulehui@huawei.com \
--cc=pulehui@huaweicloud.com \
--cc=puranjay@kernel.org \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox