public inbox for linux-riscv@lists.infradead.org
 help / color / mirror / Atom feed
From: <Conor.Dooley@microchip.com>
To: <windhl@126.com>, <palmer@dabbelt.com>,
	<paul.walmsley@sifive.com>, <aou@eecs.berkeley.edu>
Cc: <linux-riscv@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
	<lkp@intel.com>
Subject: Re: [PATCH v2] soc: sifive: (sifive_l2_cache) Add missing of_node_put()
Date: Thu, 16 Jun 2022 06:26:17 +0000	[thread overview]
Message-ID: <fe1c23cf-dab4-d926-ffef-7a8a5489a071@microchip.com> (raw)
In-Reply-To: <28cd6700.3e2d.1816b13f1fa.Coremail.windhl@126.com>

On 16/06/2022 06:54, Liang He wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> At 2022-06-16 12:49:15, "Liang He" <windhl@126.com> wrote:
>> In sifive_l2_init(), of_find_matching_node() will return a node pointer
>> with refcount incremented. We should use of_node_put() in each fail path
>> or when it is not used anymore.
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>>
>> Signed-off-by: Liang He <windhl@126.com>
>> ---
> 
> 
> Sorry, please ignore this version as it still has a bug.  I will have a strict check and compile the code before my next commit.

While you're at it - drop the Reported-by too.
You only need to include that if LKP found a problem with
a patch that's been applied already. If it's on something
in progress, just fix what it pointed out & resend.

Thanks,
Conor.

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2022-06-16  6:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-16  4:49 [PATCH v2] soc: sifive: (sifive_l2_cache) Add missing of_node_put() Liang He
2022-06-16  5:54 ` Liang He
2022-06-16  6:26   ` Conor.Dooley [this message]
2022-06-16  6:52     ` Re:Re: [PATCH " Liang He
2022-06-16  6:28 ` Conor.Dooley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fe1c23cf-dab4-d926-ffef-7a8a5489a071@microchip.com \
    --to=conor.dooley@microchip.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=lkp@intel.com \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=windhl@126.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox