Re: [PATCH v3 15/26] x86/numa_emu: use a helper function to get MAX_DMA32_PFN

David Hildenbrand
2024-08-06T13:15:33Z

On 01.08.24 08:08, Mike Rapoport wrote:
> From: "Mike Rapoport (Microsoft)" <rppt@kernel.org>
>
> This is required to make numa emulation code architecture independent so
> that it can be moved to generic code in following commits.
>
> Signed-off-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Tested-by: Zi Yan <ziy@nvidia.com> # for x86_64 and arm64
> ---
> arch/x86/include/asm/numa.h | 1 +
> arch/x86/mm/numa.c | 5 +++++
> arch/x86/mm/numa_emulation.c | 4 ++--
> 3 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/include/asm/numa.h b/arch/x86/include/asm/numa.h
> index 7017d540894a..b22c85c1ef18 100644
> --- a/arch/x86/include/asm/numa.h
> +++ b/arch/x86/include/asm/numa.h
> @@ -74,6 +74,7 @@ void debug_cpumask_set_cpu(int cpu, int node, bool enable);
> int numa_emu_cmdline(char *str);
> void __init numa_emu_update_cpu_to_node(int *emu_nid_to_phys,
> unsigned int nr_emu_nids);
> +u64 __init numa_emu_dma_end(void);
> #else /* CONFIG_NUMA_EMU */
> static inline int numa_emu_cmdline(char *str)
> {
> diff --git a/arch/x86/mm/numa.c b/arch/x86/mm/numa.c
> index 9180d524cfe4..8b7c6580d268 100644
> --- a/arch/x86/mm/numa.c
> +++ b/arch/x86/mm/numa.c
> @@ -868,6 +868,11 @@ void __init numa_emu_update_cpu_to_node(int *emu_nid_to_phys,
> __apicid_to_node[i] = j < nr_emu_nids ? j : 0;
> }
> }
> +
> +u64 __init numa_emu_dma_end(void)
> +{
> + return PFN_PHYS(MAX_DMA32_PFN);
> +}

Inline function in header?

Acked-by: David Hildenbrand <david@redhat.com>

--
Cheers,

David / dhildenb