From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00721C54ED1 for ; Tue, 27 May 2025 16:52:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=z4lr47iIWHFq/G4gJSEDQ+k0GOwuMuquT9rDuJBf1Q0=; b=wM5dFCl/CQJ3H5 N3NrP8zllFcCiJBaWCqegSrXSQFVEIAE5E2w73m8OoqmeAM1ffMoUFjRAN91enRJFluW1ZX01TOPx f+J9VmLghRmoWi/IO5qiCBtzQ+fBD84tzth7wc0aUPegzAKKs0O4rG4bA54I6gaOZN+5XdRVLc0Ln JG/K8tPmxhuw65an3cMVs91RJBALGvU4KnaEzFcrhlEP8k2BV2c7mifmGKWrcUpVvwoH+EfqdzIiL sT9IldXcaY02xEhVHR+nAvT6/T8KJE/eUbukC42URU8uuRnyqgTvL1oZSER3WkaqLdUoKnRyJUkXF 21kC9mDdexe5sj7JsVBg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uJxWz-0000000BCp5-1OFg; Tue, 27 May 2025 16:52:01 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uJxWx-0000000BCoU-0Qin; Tue, 27 May 2025 16:51:59 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 420CB614C6; Tue, 27 May 2025 16:51:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D21BCC4CEEB; Tue, 27 May 2025 16:51:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1748364718; bh=1QHtJ70y+rvjR6EHIWwb1H2O+LY90CK8zar6Avm1ejE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=q7trjF/Xiu4/dOXeYm3XARMbuTenNw4xm/v/XKKhQ3Qpz2BR/MmP9HbtTAWT9WNY2 9Ue0cdZe2532DMrkxHXjLPtpiQBle4NzeiOBgrcgpWd6Ppx42XazvV31CdT8BbCy74 9KQX1OYFF0SFkEiAAhHpgAtJ9/PnPEyhv0/MJTjyKbm++CfIKWkGfC9cRP2KpMvq6T ZGrFw2XqrcTHFs4x3c0tnOmGTbcE2umdCs2wXDsQ7CTP0SNXYrT97dRzF97KDK4DZa qTvN/hAkBUo3bs+vwWqNantVMjKirXvuqg+P6KDHImv4jJ4X0Hi5fj24rhi/sf9biw /tS8x5vXTdGbA== From: Pratyush Yadav To: Zixian Zeng Cc: Tudor Ambarus , Pratyush Yadav , Michael Walle , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Chen Wang , Inochi Amaoto , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Longbin Li , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, sophgo@lists.linux.dev, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v2 3/3] riscv: dts: sophgo: Add SPI NOR node for SG2042 In-Reply-To: <20250525-sfg-spifmc-v2-3-a3732b6f5ab4@gmail.com> References: <20250525-sfg-spifmc-v2-0-a3732b6f5ab4@gmail.com> <20250525-sfg-spifmc-v2-3-a3732b6f5ab4@gmail.com> Date: Tue, 27 May 2025 18:51:53 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Sun, May 25 2025, Zixian Zeng wrote: > Add SPI-NOR controller and flash nodes to device tree for SG2042. > > Signed-off-by: Zixian Zeng > --- > .../riscv/boot/dts/sophgo/sg2042-milkv-pioneer.dts | 18 ++++++++++++++++ > arch/riscv/boot/dts/sophgo/sg2042.dtsi | 24 ++++++++++++++++++++++ > 2 files changed, 42 insertions(+) > > diff --git a/arch/riscv/boot/dts/sophgo/sg2042-milkv-pioneer.dts b/arch/riscv/boot/dts/sophgo/sg2042-milkv-pioneer.dts > index 34645a5f6038389cd00d4940947c6bb71d39ec6f..c59a819e35d3201c484bf98392aec14392a7eb04 100644 > --- a/arch/riscv/boot/dts/sophgo/sg2042-milkv-pioneer.dts > +++ b/arch/riscv/boot/dts/sophgo/sg2042-milkv-pioneer.dts > @@ -68,6 +68,24 @@ &sd { > status = "okay"; > }; > > +&spifmc0 { > + status = "okay"; > + > + flash@0 { > + compatible = "jedec,spi-nor"; > + reg = <0>; Shouldn't you also add other properties like spi-max-frequency or spi-{rx,tx}-bus-width? Same for the other flash. > + }; > +}; > + > +&spifmc1 { > + status = "okay"; > + > + flash@0 { > + compatible = "jedec,spi-nor"; > + reg = <0>; > + }; > +}; > + > &uart0 { > status = "okay"; > }; [...] -- Regards, Pratyush Yadav _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv