Re: [External] [PATCH v2] riscv: use KERN_INFO in do_trap

yunhui cui
2024-03-20T02:20:42Z

Hi Andreas,

On Tue, Mar 19, 2024 at 11:40 PM Andreas Schwab <schwab@suse.de> wrote:
>
> Print the instruction dump with info instead of emergency level. The
> unhandled signal message is only for informational purpose.
>
> Fixes: b8a03a634129 ("riscv: add userland instruction dump to RISC-V splats")
> Signed-off-by: Andreas Schwab <schwab@suse.de>
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> v2: clarify commit message
> ---
> arch/riscv/kernel/traps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/traps.c b/arch/riscv/kernel/traps.c
> index a1b9be3c4332..142f5f5168fb 100644
> --- a/arch/riscv/kernel/traps.c
> +++ b/arch/riscv/kernel/traps.c
> @@ -121,7 +121,7 @@ void do_trap(struct pt_regs *regs, int signo, int code, unsigned long addr)
> print_vma_addr(KERN_CONT " in ", instruction_pointer(regs));
> pr_cont("\n");
> __show_regs(regs);
> - dump_instr(KERN_EMERG, regs);
> + dump_instr(KERN_INFO, regs);
> }
>
> force_sig_fault(signo, code, (void __user *)addr);
> --
> 2.44.0
>
>
> --
> Andreas Schwab, SUSE Labs, schwab@suse.de
> GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
> "And now for something completely different."

Reviewed-by: Yunhui Cui <cuiyunhui@bytedance.com>

Thanks,
Yunhui