Re: Random memory corruption with v5.2

From: Andreas Schwab <schwab@suse.de>
To: Paul Walmsley <paul.walmsley@sifive.com>
Cc: linux-riscv@lists.infradead.org, opensbi@lists.infradead.org,
	David Abdurachmanov <david.abdurachmanov@gmail.com>
Subject: Re: Random memory corruption with v5.2
Date: Thu, 01 Aug 2019 20:32:33 +0200	[thread overview]
Message-ID: <mvmwofw68ji.fsf@suse.de> (raw)
In-Reply-To: <alpine.DEB.2.21.9999.1907301709510.4874@viisi.sifive.com> (Paul Walmsley's message of "Tue, 30 Jul 2019 17:22:01 -0700 (PDT)")

On Jul 30 2019, Paul Walmsley <paul.walmsley@sifive.com> wrote:

> On Tue, 30 Jul 2019, Andreas Schwab wrote:
>
>> On Jul 30 2019, David Abdurachmanov <david.abdurachmanov@gmail.com> wrote:
>> 
>> > On Mon, Jul 29, 2019 at 1:51 PM Andreas Schwab <schwab@suse.de> wrote:
>> >>
>> >> Since switching to 5.2 kernels I'm seeing random crashes and
>> >> misbehaviors on the HiFive, for example while building gcc or glibc.
>> >> Perhaps missing TLB flushes?
>> >
>> > Do you have some examples of crashes?
>> 
>> While building glibc:
>> 
>> an_ES.UTF-8...realloc(): invalid pointer
>> /bin/sh: line 1:  7841 Aborted                 (core dumped) I18NPATH=. GCONV_PATH=/home/abuild/rpmbuild/BUILD/glibc-2.29/cc-base/iconvdata LC_ALL=C /home/abuild/rpmbuild/BUILD/glibc-2.29/cc-base/elf/ld-linux-riscv64-lp64d.so.1 --library-path /home/abuild/rpmbuild/BUILD/glibc-2.29/cc-base:/home/abuild/rpmbuild/BUILD/glibc-2.29/cc-base/math:/home/abuild/rpmbuild/BUILD/glibc-2.29/cc-base/elf:/home/abuild/rpmbuild/BUILD/glibc-2.29/cc-base/dlfcn:/home/abuild/rpmbuild/BUILD/glibc-2.29/cc-base/nss:/home/abuild/rpmbuild/BUILD/glibc-2.29/cc-base/nis:/home/abuild/rpmbuild/BUILD/glibc-2.29/cc-base/rt:/home/abuild/rpmbuild/BUILD/glibc-2.29/cc-base/resolv:/home/abuild/rpmbuild/BUILD/glibc-2.29/cc-base/mathvec:/home/abuild/rpmbuild/BUILD/glibc-2.29/cc-base/support:/home/abuild/rpmbuild/BUILD/glibc-2.29/cc-base/nptl /home/abuild/rpmbuild/BUILD/glibc-2.29/cc-base/locale/localedef $flags --alias-file=../intl/locale.alias -i locales/$input -f charmaps/$charset --prefix=/home/abuild/rpmbuild/BUILDR
 OOT/glibc-2.29-0.riscv64 $locale
>> make[2]: *** [Makefile:422: install-archive-an_ES.UTF-8/UTF-8] Error 134
>> 
>> While building gcc:
>> 
>> ../../gcc/ada/exp_aggr.adb: In function 'Exp_Aggr.Expand_N_Aggregate':
>> ../../gcc/ada/exp_aggr.adb:5311:21: warning: 'Csiz' may be used uninitialized in this function [-Wmaybe-uninitialized]
>> ../../gcc/ada/exp_aggr.adb:5220:10: note: 'Csiz' was declared here
>> +===========================GNAT BUG DETECTED==============================+
>> | 10.0.0 20190727 (experimental) [trunk revision 273844] (riscv64-suse-linux) |
>> | Storage_Error stack overflow or erroneous memory access                  |
>> | Error detected at output.ads:39:8                                        |
>> realloc(): invalid pointer
>
> I personally haven't seen these issues; but then again, I haven't done any 
> glibc or gcc builds on v5.2.  Will take a closer look.

I think there is some fundamental problem with SBI_REMOTE_SFENCE_VMA or
the kernel interface to it.

For exmaple, flush_tlb_page is defined as:

#define flush_tlb_page(vma, addr) flush_tlb_range(vma, addr, 0)

But the third argument of flush_tlb_range is supposed to be the end
address, so this should actually be:

#define flush_tlb_page(vma, addr) flush_tlb_range(vma, addr, (addr) + PAGE_SIZE)

Alas, that doesn't fix the crashes.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv