From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F2F6C4332F for ; Thu, 17 Nov 2022 14:24:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kk0+MbwYKdzS/OO5TcjKeMzrmBx42a4Y+Bih7QHawLk=; b=wGhWejaI6Da/5Z YlBGfV/gx1aM2MpY9Vfg7yJ4wU9p4MfGkQjltnE06ZGcdg2ZsS6R+btoGTmTjJgXgdviY016+3nTJ SqKYlZyduHKTZdvED+aLu85VPgBmOKehR0zYipk0ZmPmYIv04si+fs6+Gd2Q+weRZ5lhreQTWvkR+ saoR41Hd+z/L9FeEWJbVO2klqZQ1K9RRXz4LskIz0YHvh4eSrlsRUPzQfbcDg815SXdpTI5lpQw4y /YqYGyeD6mzTJQLuyOkrSXTVPnXAhUOkX/mvf1GyncTNSXeDFRq9trCMBY8nUGYE2xxhCq+AlC8rV LNzJRGoa1XXhStu/pynQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovfoT-00En5D-Jp; Thu, 17 Nov 2022 14:24:21 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovfoC-00Emxv-N0 for linux-riscv@lists.infradead.org; Thu, 17 Nov 2022 14:24:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668695043; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ero3Dop74ZUrxw/cst3yMxEJhDrRdAAQvlUsX3escHg=; b=KgjWlvtCKJUHs+tKAAL/SCLIigkCVUC7V242kw6Lq8Z3W//ZjUhguA8g/h8LwqO7AAsS8R /8xe45O5qev6v8hLRYmygDKTB2aEyPX/5PHpx/wk7Gn1MaMQ8JOZNkSOnlNuY2Q4IYVsp8 iT09hQDK5hg5e1ej3uuQVSaPknxhZaw= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-120-U29LXYTIOpy06Nm1vALEGQ-1; Thu, 17 Nov 2022 09:24:01 -0500 X-MC-Unique: U29LXYTIOpy06Nm1vALEGQ-1 Received: by mail-wm1-f70.google.com with SMTP id h9-20020a1c2109000000b003cfd37aec58so717548wmh.1 for ; Thu, 17 Nov 2022 06:24:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ero3Dop74ZUrxw/cst3yMxEJhDrRdAAQvlUsX3escHg=; b=1BdwipacsyU/O4IUNU2fJDgl7a331tJ9TZJz74eXgGGlRjqH2Y+2RjCj3zzhjoD7/C WNnNZfM26fJutymT/Vr3AAW+OjWPiziI9DVhuDr95rOqVmTj3ZgyqPbYSdGE3AoO5ETC HyWlxC8sMk4fvP2Uy+aKy/KTVH5ZR3z85G01ouGUYm2iZSACig4Zjq/jpkQnh1K71pAk eHPt6i9BQ1ZTUS7+9nBZk8Cx3Xk7lXbmubty9z35U1FAS46G89CTgZr+prY6yHiUPLz5 1mLP8uM0M1m5pybREPvh25GF7bxGK6z9ZTU97iEFgnSpt2ka+mJnCstAzagQvDO1Waix GIJA== X-Gm-Message-State: ANoB5plJMh9uN5kC8V9iRc3LYQHN24jG8DYaOhm7bG69oFFlSu4z0SSW 0m4SDG14QYJ6kFMbspCykfW5uIg5F3IeCc+1OP+/8YUNV30GGkbLaSmpcBGoJp5lDq1jxp7PqTe F/5MyqKkCkINWzoE7b2tPcFAwCbrY X-Received: by 2002:a5d:58fb:0:b0:236:74c5:1b2d with SMTP id f27-20020a5d58fb000000b0023674c51b2dmr1616717wrd.14.1668695040746; Thu, 17 Nov 2022 06:24:00 -0800 (PST) X-Google-Smtp-Source: AA0mqf7dCrVGloFO6BdNbsi4gADz4iCuS/nJ5b5vEmtvQw4WeirpWLMINwzrWmZ6QxU1sPuLDe40QQ== X-Received: by 2002:a5d:58fb:0:b0:236:74c5:1b2d with SMTP id f27-20020a5d58fb000000b0023674c51b2dmr1616704wrd.14.1668695040586; Thu, 17 Nov 2022 06:24:00 -0800 (PST) Received: from vschneid.remote.csb ([154.57.232.159]) by smtp.gmail.com with ESMTPSA id t11-20020adff60b000000b0022e035a4e93sm1096445wrp.87.2022.11.17.06.23.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Nov 2022 06:23:59 -0800 (PST) From: Valentin Schneider To: Peter Zijlstra Cc: linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org, x86@kernel.org, "Paul E. McKenney" , Steven Rostedt , Thomas Gleixner , Sebastian Andrzej Siewior , Juri Lelli , Daniel Bristot de Oliveira , Marcelo Tosatti , Frederic Weisbecker , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Marc Zyngier , Mark Rutland , Russell King , Nicholas Piggin , Guo Ren , "David S. Miller" Subject: Re: [RFC PATCH v2 4/8] smp: Trace IPIs sent via arch_send_call_function_ipi_mask() In-Reply-To: References: <20221102182949.3119584-1-vschneid@redhat.com> <20221102183336.3120536-3-vschneid@redhat.com> Date: Thu, 17 Nov 2022 14:23:55 +0000 Message-ID: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221117_062404_868290_E3553A89 X-CRM114-Status: GOOD ( 16.01 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 17/11/22 10:08, Peter Zijlstra wrote: > On Wed, Nov 02, 2022 at 06:33:32PM +0000, Valentin Schneider wrote: >> This simply wraps around the arch function and prepends it with a >> tracepoint, similar to send_call_function_single_ipi(). >> >> Signed-off-by: Valentin Schneider >> --- >> kernel/smp.c | 9 ++++++++- >> 1 file changed, 8 insertions(+), 1 deletion(-) >> >> diff --git a/kernel/smp.c b/kernel/smp.c >> index e2ca1e2f31274..c4d561cf50d45 100644 >> --- a/kernel/smp.c >> +++ b/kernel/smp.c >> @@ -160,6 +160,13 @@ void __init call_function_init(void) >> smpcfd_prepare_cpu(smp_processor_id()); >> } >> >> +static inline void > > Given the use of _RET_IP_, I would strongly recommend you use > __always_inline. > Noted, thanks >> +send_call_function_ipi_mask(const struct cpumask *mask) >> +{ >> + trace_ipi_send_cpumask(mask, _RET_IP_, func); > > What's func? > A rebase fail... That's only plugged in later. >> + arch_send_call_function_ipi_mask(mask); >> +} _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv