From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jingoo Han" Subject: Re: [RESEND PATCH v6 16/27] drm/bridge: analogix_dp: Fix incorrect operations with register ANALOGIX_DP_FUNC_EN_1 Date: Mon, 23 Apr 2018 21:29:04 -0400 Message-ID: <000101d3db6b$a2a14d20$e7e3e760$@gmail.com> References: <20180423105003.9004-1-enric.balletbo@collabora.com> <20180423105003.9004-17-enric.balletbo@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180423105003.9004-17-enric.balletbo@collabora.com> Content-Language: en-us List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: 'Enric Balletbo i Serra' , architt@codeaurora.org, inki.dae@samsung.com, thierry.reding@gmail.com, hjc@rock-chips.com, seanpaul@chromium.org, airlied@linux.ie, tfiga@chromium.org, heiko@sntech.de Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Laurent.pinchart@ideasonboard.com, kernel@collabora.com, m.szyprowski@samsung.com, linux-samsung-soc@vger.kernel.org, rydberg@bitmath.org, krzk@kernel.org, linux-rockchip@lists.infradead.org, kgene@kernel.org, orjan.eide@arm.com, wxt@rock-chips.com, jeffy.chen@rock-chips.com, linux-arm-kernel@lists.infradead.org, wzz@rock-chips.com, hl@rock-chips.com, sw0312.kim@samsung.com, dianders@chromium.org, kyungmin.park@samsung.com, kuankuan.y@gmail.com, hshi@chromium.org List-Id: linux-rockchip.vger.kernel.org T24gTW9uZGF5LCBBcHJpbCAyMywgMjAxOCA2OjUwIEFNLCBFbnJpYyBCYWxsZXRibyBpIFNlcnJh IHdyb3RlOgo+IAo+IEZyb206IHphaW4gd2FuZyA8d3p6QHJvY2stY2hpcHMuY29tPgo+IAo+IFJl Z2lzdGVyIEFOQUxPR0lYX0RQX0ZVTkNfRU5fMShvZmZzZXQgMHgxOCksIFJvY2tjaGlwIGlzIGRp ZmZlcmVudCB0bwo+IEV4eW5vczoKPiAKPiBvbiBFeHlub3MgZWRwIHBoeSwKPiBCSVQgNwkJTUFT VEVSX1ZJRF9GVU5DX0VOX04KPiBCSVQgNgkJcmVzZXJ2ZWQKPiBCSVQgNQkJU0xBVkVfVklEX0ZV TkNfRU5fTgo+IAo+IG9uIFJvY2tjaGlwIGVkcCBwaHksCj4gQklUIDcJCXJlc2VydmVkCj4gQklU IDYJCVJLX1ZJRF9DQVBfRlVOQ19FTl9OCj4gQklUIDUJCVJLX1ZJRF9GSUZPX0ZVTkNfRU5fTgo+ IAo+IFNvLCB3ZSBzaG91bGQgZG8gc29tZSBwcml2YXRlIG9wZXJhdGlvbnMgdG8gUm9ja2NoaXAu Cj4gCj4gQ2M6IFRvbWFzeiBGaWdhIDx0ZmlnYUBjaHJvbWl1bS5vcmc+Cj4gU2lnbmVkLW9mZi1i eTogemFpbiB3YW5nIDx3enpAcm9jay1jaGlwcy5jb20+Cj4gU2lnbmVkLW9mZi1ieTogU2VhbiBQ YXVsIDxzZWFucGF1bEBjaHJvbWl1bS5vcmc+Cj4gU2lnbmVkLW9mZi1ieTogVGhpZXJyeSBFc2Nh bmRlIDx0aGllcnJ5LmVzY2FuZGVAY29sbGFib3JhLmNvbT4KPiBSZXZpZXdlZC1ieTogQW5kcnpl aiBIYWpkYSA8YS5oYWpkYUBzYW1zdW5nLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBFbnJpYyBCYWxs ZXRibyBpIFNlcnJhIDxlbnJpYy5iYWxsZXRib0Bjb2xsYWJvcmEuY29tPgo+IFRlc3RlZC1ieTog TWFyZWsgU3p5cHJvd3NraSA8bS5zenlwcm93c2tpQHNhbXN1bmcuY29tPgo+IFJldmlld2VkLWJ5 OiBBcmNoaXQgVGFuZWphIDxhcmNoaXR0QGNvZGVhdXJvcmEub3JnPgoKQWNrZWQtYnk6IEppbmdv byBIYW4gPGppbmdvb2hhbjFAZ21haWwuY29tPgoKQmVzdCByZWdhcmRzLApKaW5nb28gSGFuCgo+ IC0tLQo+IAo+ICAuLi4vZ3B1L2RybS9icmlkZ2UvYW5hbG9naXgvYW5hbG9naXhfZHBfcmVnLmMg fCAxOSArKysrKysrKysrKysrKy0tLS0tCj4gIC4uLi9ncHUvZHJtL2JyaWRnZS9hbmFsb2dpeC9h bmFsb2dpeF9kcF9yZWcuaCB8ICAyICsrCj4gIDIgZmlsZXMgY2hhbmdlZCwgMTYgaW5zZXJ0aW9u cygrKSwgNSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2Jy aWRnZS9hbmFsb2dpeC9hbmFsb2dpeF9kcF9yZWcuYwo+IGIvZHJpdmVycy9ncHUvZHJtL2JyaWRn ZS9hbmFsb2dpeC9hbmFsb2dpeF9kcF9yZWcuYwo+IGluZGV4IDAyYWIxYWFhOTk5My4uNGVhZTIw NmVjMzFiIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYW5hbG9naXgvYW5h bG9naXhfZHBfcmVnLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2FuYWxvZ2l4L2Fu YWxvZ2l4X2RwX3JlZy5jCj4gQEAgLTEyNiw5ICsxMjYsMTQgQEAgdm9pZCBhbmFsb2dpeF9kcF9y ZXNldChzdHJ1Y3QgYW5hbG9naXhfZHBfZGV2aWNlICpkcCkKPiAgCWFuYWxvZ2l4X2RwX3N0b3Bf dmlkZW8oZHApOwo+ICAJYW5hbG9naXhfZHBfZW5hYmxlX3ZpZGVvX211dGUoZHAsIDApOwo+IAo+ IC0JcmVnID0gTUFTVEVSX1ZJRF9GVU5DX0VOX04gfCBTTEFWRV9WSURfRlVOQ19FTl9OIHwKPiAt CQlBVURfRklGT19GVU5DX0VOX04gfCBBVURfRlVOQ19FTl9OIHwKPiAtCQlIRENQX0ZVTkNfRU5f TiB8IFNXX0ZVTkNfRU5fTjsKPiArCWlmIChkcC0+cGxhdF9kYXRhICYmIGlzX3JvY2tjaGlwKGRw LT5wbGF0X2RhdGEtPmRldl90eXBlKSkKPiArCQlyZWcgPSBSS19WSURfQ0FQX0ZVTkNfRU5fTiB8 IFJLX1ZJRF9GSUZPX0ZVTkNfRU5fTiB8Cj4gKwkJCVNXX0ZVTkNfRU5fTjsKPiArCWVsc2UKPiAr CQlyZWcgPSBNQVNURVJfVklEX0ZVTkNfRU5fTiB8IFNMQVZFX1ZJRF9GVU5DX0VOX04gfAo+ICsJ CQlBVURfRklGT19GVU5DX0VOX04gfCBBVURfRlVOQ19FTl9OIHwKPiArCQkJSERDUF9GVU5DX0VO X04gfCBTV19GVU5DX0VOX047Cj4gKwo+ICAJd3JpdGVsKHJlZywgZHAtPnJlZ19iYXNlICsgQU5B TE9HSVhfRFBfRlVOQ19FTl8xKTsKPiAKPiAgCXJlZyA9IFNTQ19GVU5DX0VOX04gfCBBVVhfRlVO Q19FTl9OIHwKPiBAQCAtOTcxLDggKzk3NiwxMiBAQCB2b2lkIGFuYWxvZ2l4X2RwX2NvbmZpZ192 aWRlb19zbGF2ZV9tb2RlKHN0cnVjdAo+IGFuYWxvZ2l4X2RwX2RldmljZSAqZHApCj4gIAl1MzIg cmVnOwo+IAo+ICAJcmVnID0gcmVhZGwoZHAtPnJlZ19iYXNlICsgQU5BTE9HSVhfRFBfRlVOQ19F Tl8xKTsKPiAtCXJlZyAmPSB+KE1BU1RFUl9WSURfRlVOQ19FTl9OIHwgU0xBVkVfVklEX0ZVTkNf RU5fTik7Cj4gLQlyZWcgfD0gTUFTVEVSX1ZJRF9GVU5DX0VOX047Cj4gKwlpZiAoZHAtPnBsYXRf ZGF0YSAmJiBpc19yb2NrY2hpcChkcC0+cGxhdF9kYXRhLT5kZXZfdHlwZSkpIHsKPiArCQlyZWcg Jj0gfihSS19WSURfQ0FQX0ZVTkNfRU5fTiB8IFJLX1ZJRF9GSUZPX0ZVTkNfRU5fTik7Cj4gKwl9 IGVsc2Ugewo+ICsJCXJlZyAmPSB+KE1BU1RFUl9WSURfRlVOQ19FTl9OIHwgU0xBVkVfVklEX0ZV TkNfRU5fTik7Cj4gKwkJcmVnIHw9IE1BU1RFUl9WSURfRlVOQ19FTl9OOwo+ICsJfQo+ICAJd3Jp dGVsKHJlZywgZHAtPnJlZ19iYXNlICsgQU5BTE9HSVhfRFBfRlVOQ19FTl8xKTsKPiAKPiAgCXJl ZyA9IHJlYWRsKGRwLT5yZWdfYmFzZSArIEFOQUxPR0lYX0RQX1ZJREVPX0NUTF8xMCk7Cj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYW5hbG9naXgvYW5hbG9naXhfZHBfcmVn LmgKPiBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYW5hbG9naXgvYW5hbG9naXhfZHBfcmVnLmgK PiBpbmRleCBiNjMzYTRhNTA4MmEuLjBjZjI3YzczMTcyNyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vYnJpZGdlL2FuYWxvZ2l4L2FuYWxvZ2l4X2RwX3JlZy5oCj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2JyaWRnZS9hbmFsb2dpeC9hbmFsb2dpeF9kcF9yZWcuaAo+IEBAIC0xMjcsNyAr MTI3LDkgQEAKPiAKPiAgLyogQU5BTE9HSVhfRFBfRlVOQ19FTl8xICovCj4gICNkZWZpbmUgTUFT VEVSX1ZJRF9GVU5DX0VOX04JCQkoMHgxIDw8IDcpCj4gKyNkZWZpbmUgUktfVklEX0NBUF9GVU5D X0VOX04JCQkoMHgxIDw8IDYpCj4gICNkZWZpbmUgU0xBVkVfVklEX0ZVTkNfRU5fTgkJCSgweDEg PDwgNSkKPiArI2RlZmluZSBSS19WSURfRklGT19GVU5DX0VOX04JCQkoMHgxIDw8IDUpCj4gICNk ZWZpbmUgQVVEX0ZJRk9fRlVOQ19FTl9OCQkJKDB4MSA8PCA0KQo+ICAjZGVmaW5lIEFVRF9GVU5D X0VOX04JCQkJKDB4MSA8PCAzKQo+ICAjZGVmaW5lIEhEQ1BfRlVOQ19FTl9OCQkJCSgweDEgPDwg MikKPiAtLQo+IDIuMTcuMAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Ry aS1kZXZlbAo=