From: Dragan Simic <dsimic@manjaro.org>
To: Sergey Bostandzhyan <jin@mediatomb.cc>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
heiko@sntech.de, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] arm64: dts: rockchip: improve eMMC speed on NanoPi R2S Plus
Date: Fri, 16 Aug 2024 08:51:40 +0200 [thread overview]
Message-ID: <002107db3dcf3f1d1d1a767f049b5b79@manjaro.org> (raw)
In-Reply-To: <20240814170048.23816-4-jin@mediatomb.cc>
Hello Sergey,
On 2024-08-14 19:00, Sergey Bostandzhyan wrote:
> This change has been suggested by Daniel Golle during patch review,
> adding mmc-hs200-1_8v; makes sure that eMMC gets detected as HS200
> which improves it's performance.
Describing who suggested the patch in the patch description looks
out of place. Instead, you should add a Suggested-by tag, whose
purpose is exactly to describe who suggested the patch.
> Signed-off-by: Sergey Bostandzhyan <jin@mediatomb.cc>
> ---
> arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts
> b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts
> index 12eabdbf8fe8..146b1da198b8 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts
> @@ -23,6 +23,7 @@
> cap-mmc-highspeed;
> supports-emmc;
> disable-wp;
> + mmc-hs200-1_8v;
> non-removable;
> num-slots = <1>;
> pinctrl-names = "default";
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2024-08-16 6:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 17:00 [PATCH v3 0/3] Add DTS for NanoPi R2S Plus Sergey Bostandzhyan
2024-08-14 17:00 ` [PATCH v3 1/3] arm64: dts: rockchip: Add DTS for FriendlyARM " Sergey Bostandzhyan
2024-08-14 17:00 ` [PATCH v3 2/3] dt-bindings: arm: rockchip: Add " Sergey Bostandzhyan
2024-08-14 17:00 ` [PATCH v3 3/3] arm64: dts: rockchip: improve eMMC speed on " Sergey Bostandzhyan
2024-08-16 6:51 ` Dragan Simic [this message]
2024-08-16 10:10 ` Sergey 'Jin' Bostandzhyan
2024-08-16 10:16 ` Heiko Stübner
2024-08-15 18:28 ` [PATCH v3 0/3] Add DTS for " Rob Herring (Arm)
2024-08-15 20:18 ` Heiko Stuebner
2024-08-15 23:26 ` Sergey 'Jin' Bostandzhyan
2024-08-25 16:28 ` m.plak
2024-08-26 9:12 ` Sergey 'Jin' Bostandzhyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=002107db3dcf3f1d1d1a767f049b5b79@manjaro.org \
--to=dsimic@manjaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jin@mediatomb.cc \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox