From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 213D8FF886D for ; Tue, 28 Apr 2026 14:10:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=F+PTmScTzBKRzDnVU072wVbvlX4N8L7QSz5a9lL+jUs=; b=USgksj23KfP2Qq lVb45wYejOE7WOyr9g8F4GuyredLDHf9Z5oyHj4+KqtC4Qo4XN/8/qpsWTY//+CmLj65ixpEkJsLF Hq4y6zWp0TmX124ybf6T5Hopo/luGzuoCcKvh92T+jfL2yOj8TYcWeg3H6TlF/JfuVE440RQMP/BF hEqONHT9WRzgm24z74KlhK8rD7NzxJHiwBXwEmYQcXrLX0k+h+RZ61Cn7cFPrK3GGKQsVI2cz0JiU caP7vilveAg48DJYPZcW8ILwGABKiABswYlipFntusKDbfZ8x+tYIStNZXTGOknj3gZ+J9edOyCKs 6n07o1tHk2voOUP3+lvg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wHj9I-00000001cP2-3MLO; Tue, 28 Apr 2026 14:10:52 +0000 Received: from bali.collaboradmins.com ([148.251.105.195]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wHj9D-00000001cMX-2wc4; Tue, 28 Apr 2026 14:10:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1777385444; bh=8U5hrdolA+y+3mG3AaoqX+B0mjaYuFRJDFtJJ0yiStI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=FI4BMrG1hXG2CerAkIE98HWuFW4UGy71R5db0fNotmySofWyeW+iVcXPxvj6L6OBO OuClsBXSPBt6WHzbHsqRrn1Nkvn5ERDROxWu2iXCbJr2geCJiG8iYVbZPNhOg64BFy 28x/mBtxR1nCBPwiQGuogAJvCv1Dp4dkhh3x6FwAkkb7qrze5JAC8qMUllLMqgtBZA 9gRnnTqDg1JXTwrVCdNa71Jpi+JsyhkJ5RSkE8RtgdmG2OqoKZ0ALopGmbE1aCKZj4 fJVxqJu0V1Rm8sQzZxiE75pnLa9Dmiv4UNp787Fo4Rc0/uPvCGmQGXJKI1LZ/aHGHk RtAxW/IvSxjRg== Received: from [100.64.0.241] (unknown [100.64.0.241]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id 16D9917E128F; Tue, 28 Apr 2026 16:10:44 +0200 (CEST) Message-ID: <0143075a-098e-4275-b152-419700e4b7c0@collabora.com> Date: Tue, 28 Apr 2026 17:10:43 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 10/10] drm/rockchip: dw_hdmi_qp: Restrict HPD event to the affected connector To: Dmitry Baryshkov Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Andy Yan , kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Diederik de Haas , Maud Spierings References: <20260426-dw-hdmi-qp-scramb-v5-0-d778e70c317b@collabora.com> <20260426-dw-hdmi-qp-scramb-v5-10-d778e70c317b@collabora.com> Content-Language: en-US From: Cristian Ciocaltea In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260428_071047_903658_01908BF9 X-CRM114-Status: GOOD ( 12.15 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On 4/28/26 4:53 AM, Dmitry Baryshkov wrote: > On Sun, Apr 26, 2026 at 03:20:22AM +0300, Cristian Ciocaltea wrote: >> Switch from drm_helper_hpd_irq_event(), which polls all connectors, to >> drm_connector_helper_hpd_irq_event(), which runs the detect cycle only >> on the affected connector. >> >> This avoids unnecessary work and redundant detect calls on unrelated >> connectors. > > This also doesn't feel correct. The dw_hdmi_qp is a bridge. As such it > should be using drm_bridge_hpd_notify() rather than any of the mentioned > functions. Would it be better to add the a corresponding wrapper to the > dw_hdmi_qp API and call one there? Let me try that. > Also consider implementing the > .hpd_enable() and .hpd_disable() callbacks for the bridge, which would > remove the necessity to call enable the IRQ in the bind function. Ack. Thanks, Cristian _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip