public inbox for linux-rockchip@lists.infradead.org
 help / color / mirror / Atom feed
From: Dragan Simic <dsimic@manjaro.org>
To: Heiko Stuebner <heiko@sntech.de>
Cc: linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	quentin.schulz@theobroma-systems.com
Subject: Re: [PATCH 0/4] arm64: dts: rockchip: aliases for core busses in main dtsi
Date: Fri, 01 Dec 2023 18:19:51 +0100	[thread overview]
Message-ID: <034a3f8712f8405113a92a1e1969e94e@manjaro.org> (raw)
In-Reply-To: <20231201165810.334212-1-heiko@sntech.de>

On 2023-12-01 17:58, Heiko Stuebner wrote:
> Placement of aliases is cause for a lot of discussion :-).
> Most recently in [0]. And while devices such as mmc controllers do have
> names not following any numbers, this is different for the core
> busses/devices like serial, i2c, gpio, spi.
> 
> All of those start at number 0 and increment then. And all pieces of
> documentation like soc manuals, device schematics as well as pin-header
> descriptions for SBCs also use these numbers to identify the controller
> instance.
> 
> All previous Rockchip socs also carry those core busses in the main 
> dtsi
> so that not every board needs to have the exact same aliases defined.
> 
> [0] https://lore.kernel.org/all/4762834.KRxA6XjA2N@diego/
> 
> Heiko Stuebner (4):
>   arm64: dts: rockchip: move rk3588 serial aliases to soc dtsi
>   arm64: dts: rockchip: add rk3588 i2c aliases to soc dtsi
>   arm64: dts: rockchip: add rk3588 gpio aliases to soc dtsi
>   arm64: dts: rockchip: add rk3588 spi aliases to soc dtsi
> 
>  .../dts/rockchip/rk3588-edgeble-neu6a-io.dts  |  4 ---
>  .../dts/rockchip/rk3588-edgeble-neu6b-io.dts  |  4 ---
>  .../boot/dts/rockchip/rk3588-evb1-v10.dts     |  1 -
>  .../boot/dts/rockchip/rk3588-nanopc-t6.dts    |  1 -
>  .../dts/rockchip/rk3588-orangepi-5-plus.dts   |  1 -
>  .../boot/dts/rockchip/rk3588-quartzpro64.dts  |  1 -
>  .../boot/dts/rockchip/rk3588-rock-5b.dts      |  1 -
>  .../boot/dts/rockchip/rk3588-turing-rk1.dtsi  |  2 --
>  .../dts/rockchip/rk3588s-indiedroid-nova.dts  |  1 -
>  .../dts/rockchip/rk3588s-khadas-edge2.dts     |  1 -
>  .../boot/dts/rockchip/rk3588s-orangepi-5.dts  |  1 -
>  .../boot/dts/rockchip/rk3588s-rock-5a.dts     |  1 -
>  arch/arm64/boot/dts/rockchip/rk3588s.dtsi     | 32 +++++++++++++++++++
>  13 files changed, 32 insertions(+), 19 deletions(-)

Thank you for cleaning this up.  Here's my Reviewed-by for the entire 
series:

Reviewed-by: Dragan Simic <dsimic@manjaro.org>

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

      parent reply	other threads:[~2023-12-01 17:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-01 16:58 [PATCH 0/4] arm64: dts: rockchip: aliases for core busses in main dtsi Heiko Stuebner
2023-12-01 16:58 ` [PATCH 1/4] arm64: dts: rockchip: move rk3588 serial aliases to soc dtsi Heiko Stuebner
2023-12-01 16:58 ` [PATCH 2/4] arm64: dts: rockchip: add rk3588 i2c " Heiko Stuebner
2023-12-01 16:58 ` [PATCH 3/4] arm64: dts: rockchip: add rk3588 gpio " Heiko Stuebner
2023-12-01 17:23   ` Diederik de Haas
2023-12-01 17:25     ` Heiko Stübner
2023-12-01 16:58 ` [PATCH 4/4] arm64: dts: rockchip: add rk3588 spi " Heiko Stuebner
2023-12-01 17:19 ` Dragan Simic [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=034a3f8712f8405113a92a1e1969e94e@manjaro.org \
    --to=dsimic@manjaro.org \
    --cc=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=quentin.schulz@theobroma-systems.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox