From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Sascha Hauer <s.hauer@pengutronix.de>, dri-devel@lists.freedesktop.org
Cc: devicetree@vger.kernel.org,
Benjamin Gaignard <benjamin.gaignard@collabora.com>,
Peter Geis <pgwipeout@gmail.com>,
Sandy Huang <hjc@rock-chips.com>,
linux-rockchip@lists.infradead.org,
Michael Riesch <michael.riesch@wolfvision.net>,
kernel@pengutronix.de, Andy Yan <andy.yan@rock-chips.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 22/23] drm: rockchip: Add VOP2 driver
Date: Tue, 15 Feb 2022 22:47:39 +0300 [thread overview]
Message-ID: <09ed17be-5780-011b-6801-87a5afd4e907@collabora.com> (raw)
In-Reply-To: <20220209095350.2104049-23-s.hauer@pengutronix.de>
09.02.2022 12:53, Sascha Hauer пишет:
> +static irqreturn_t vop2_isr(int irq, void *data)
> +{
> + struct vop2 *vop2 = data;
> + const struct vop2_data *vop2_data = vop2->data;
> + uint32_t axi_irqs[VOP2_SYS_AXI_BUS_NUM];
> + int ret = IRQ_NONE;
> + int i;
> +
> + /*
> + * The irq is shared with the iommu. If the runtime-pm state of the
> + * vop2-device is disabled the irq has to be targeted at the iommu.
> + */
> + if (!pm_runtime_get_if_in_use(vop2->dev))
> + return IRQ_NONE;
> +
> + for (i = 0; i < vop2_data->nr_vps; i++) {
> + struct vop2_video_port *vp = &vop2->vps[i];
> + struct drm_crtc *crtc = &vp->crtc;
> + uint32_t irqs;
> +
> + irqs = vop2_readl(vop2, RK3568_VP_INT_STATUS(vp->id));
> + vop2_writel(vop2, RK3568_VP_INT_CLR(vp->id), irqs << 16 | irqs);
> +
> + if (irqs & VP_INT_DSP_HOLD_VALID) {
> + complete(&vp->dsp_hold_completion);
> + ret = IRQ_HANDLED;
> + }
> +
> + if (irqs & VP_INT_FS_FIELD) {
> + unsigned long flags;
> +
> + drm_crtc_handle_vblank(crtc);
> + spin_lock_irqsave(&crtc->dev->event_lock, flags);
IRQ is disabled inside of ISR(), no need to save/restore the flags.
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2022-02-15 19:48 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 9:53 [PATCH v5 00/23] drm/rockchip: RK356x VOP2 support Sascha Hauer
2022-02-09 9:53 ` [PATCH v5 01/23] drm/encoder: Add of_graph port to struct drm_encoder Sascha Hauer
2022-02-09 10:07 ` Sascha Hauer
2022-02-09 11:12 ` Jani Nikula
2022-02-10 11:52 ` Sascha Hauer
2022-02-10 15:22 ` Sascha Hauer
2022-02-09 9:53 ` [PATCH v5 02/23] drm/rockchip: dw_hdmi: Do not leave clock enabled in error case Sascha Hauer
2022-02-09 10:03 ` Heiko Stübner
2022-02-09 9:53 ` [PATCH v5 03/23] drm/rockchip: dw_hdmi: rename vpll clock to reference clock Sascha Hauer
2022-02-09 9:53 ` [PATCH v5 04/23] dt-bindings: display: rockchip: dw-hdmi: use "ref" as clock name Sascha Hauer
2022-02-09 9:53 ` [PATCH v5 05/23] arm64: dts: rockchip: rk3399: rename HDMI ref clock to 'ref' Sascha Hauer
2022-02-09 9:53 ` [PATCH v5 06/23] drm/rockchip: dw_hdmi: add rk3568 support Sascha Hauer
2022-02-09 9:53 ` [PATCH v5 07/23] dt-bindings: display: rockchip: dw-hdmi: Add compatible for rk3568 HDMI Sascha Hauer
2022-02-09 9:53 ` [PATCH v5 08/23] drm/rockchip: dw_hdmi: add regulator support Sascha Hauer
2022-02-09 9:53 ` [PATCH v5 09/23] dt-bindings: display: rockchip: dw-hdmi: Add " Sascha Hauer
2022-02-09 9:53 ` [PATCH v5 10/23] drm/rockchip: dw_hdmi: Add support for hclk Sascha Hauer
2022-02-15 19:50 ` Dmitry Osipenko
2022-02-09 9:53 ` [PATCH v5 11/23] dt-bindings: display: rockchip: dw-hdmi: Add additional clock Sascha Hauer
2022-02-09 9:53 ` [PATCH v5 12/23] drm/rockchip: dw_hdmi: Use auto-generated tables Sascha Hauer
2022-02-09 10:06 ` Heiko Stübner
2022-02-09 9:53 ` [PATCH v5 13/23] drm/rockchip: dw_hdmi: drop mode_valid hook Sascha Hauer
2022-02-09 9:53 ` [PATCH v5 14/23] drm/rockchip: dw_hdmi: Set cur_ctr to 0 always Sascha Hauer
2022-02-09 9:53 ` [PATCH v5 15/23] drm/rockchip: dw_hdmi: add default 594Mhz clk for 4K@60hz Sascha Hauer
2022-02-09 9:53 ` [PATCH v5 16/23] dt-bindings: display: rockchip: dw-hdmi: Make unwedge pinctrl optional Sascha Hauer
2022-02-09 9:53 ` [PATCH v5 17/23] arm64: dts: rockchip: rk356x: Add VOP2 nodes Sascha Hauer
2022-02-09 9:53 ` [PATCH v5 18/23] arm64: dts: rockchip: rk356x: Add HDMI nodes Sascha Hauer
2022-02-09 9:53 ` [PATCH v5 19/23] arm64: dts: rockchip: rk3568-evb: Enable VOP2 and hdmi Sascha Hauer
2022-02-10 0:10 ` Johan Jonker
2022-02-10 11:47 ` Sascha Hauer
2022-02-10 13:15 ` Johan Jonker
2022-02-10 13:37 ` Sascha Hauer
2022-02-10 13:51 ` Heiko Stübner
2022-02-09 9:53 ` [PATCH v5 20/23] arm64: dts: rockchip: enable vop2 and hdmi tx on quartz64a Sascha Hauer
2022-02-09 9:53 ` [PATCH v5 21/23] drm/rockchip: Make VOP driver optional Sascha Hauer
2022-02-09 9:53 ` [PATCH v5 22/23] drm: rockchip: Add VOP2 driver Sascha Hauer
2022-02-09 20:13 ` Aw: " Frank Wunderlich
2022-02-10 6:50 ` Michael Riesch
2022-02-15 19:47 ` Dmitry Osipenko
2022-02-15 19:47 ` Dmitry Osipenko [this message]
2022-02-15 19:47 ` Dmitry Osipenko
2022-02-16 10:39 ` Dmitry Osipenko
2022-02-16 11:22 ` Sascha Hauer
2022-02-16 12:23 ` Dmitry Osipenko
2022-02-09 9:53 ` [PATCH v5 23/23] dt-bindings: display: rockchip: Add binding for VOP2 Sascha Hauer
2022-02-09 18:56 ` Rob Herring
2022-02-09 17:44 ` Aw: [PATCH v5 00/23] drm/rockchip: RK356x VOP2 support Frank Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09ed17be-5780-011b-6801-87a5afd4e907@collabora.com \
--to=dmitry.osipenko@collabora.com \
--cc=andy.yan@rock-chips.com \
--cc=benjamin.gaignard@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hjc@rock-chips.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=michael.riesch@wolfvision.net \
--cc=pgwipeout@gmail.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox