From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C804C7115B for ; Sat, 21 Jun 2025 01:52:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jLwhGT+DUpt16Xy5ijRJY48rVg2Jf93ET1jKLw8LBfQ=; b=SPCOtabrjr5DxR 4Xbwqv7tKHSTRDqC/aroiH1AHlSfGn90r60YItznBhPEgpFGUg8iglwCdl//w3Tvg3KKRV0XZJ1si thfGwUnNxId5smfIryyR4ij7urGOVk2Ht2xd07bcMRRUZruN5ge6IUdkE/K6OhAfO4IMmGVdGnQ9o 72LFPitcBCB4qFambpmSD+tccO7ZsakZw9rRuVCAKfdWgjZztkbh+AavuZhTwcVYhQeBn9EZPZjzh SZ4jA8vpu3nQlf3okUwH7JyEdytTNLJEKkiTACmQ4A25IrCAhPK6xxmeW5yiVyfQoeqP3ItZ8uQSL 6ysrQZgoKpGZ7jCrBdaw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uSnPS-0000000GwRy-06Jo; Sat, 21 Jun 2025 01:52:46 +0000 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uSnLR-0000000Gvyc-17lX; Sat, 21 Jun 2025 01:48:38 +0000 Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-235ef62066eso31743755ad.3; Fri, 20 Jun 2025 18:48:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750470516; x=1751075316; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rtc4GJjYIzCc3h+Hv3COhOArvofrVT3IhU2L5CEaYbA=; b=YipKJjYUGd5dSDpdfDIakdxv22gnvuAExq9W6QmiFM9FmvpwNfrZ16iQH2++jBvbL3 n5EB3Zl/rlxs6sHDW2t5JI/KR+vu9ND5LDc0mMIFYo46nYZ8qzVO+8Ong/2fpWLyRk8n 66B4/o3CRooEq2fRv4XCrLWZ7grQlV7cWQ51fXc+JZOBVV2oawNUVHTorugP3aziYqQK t9fXDsmZAvcx9N9NGrXoTtjKsPTP+1maJXU4CDhLDwKU6zhu8wi3T0AhuP8GKI89q3hr 8AEUrd0E+TUOta5gMZRjHgRAjWm4P3JRsbWbHXbU/A3EagmcGj3xmatXDxzch6PDMd7T JI2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750470516; x=1751075316; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rtc4GJjYIzCc3h+Hv3COhOArvofrVT3IhU2L5CEaYbA=; b=MFUTUQBUPUl5lY8COQE56HXQYdREcXWUgwc68NksB0H85O2UtxBTnnYqObwNFQRF5n fmCgLHdOyktuWdw6lAIhJUAf0BfU4SU+VNiuvmv1aYUxw8pXgq3J9RUtBc+W9MXOYKQq W2tCyJ+3ozx7rCBtexjsE37nhZECizGIdmgE35RtX/h0LRglInbgoSuQeVX8O1GdwxiV VZsxBxeZpMCloOZS2ecJTvdV0MCyn0M9b8i/N6ywBLfxRHuUF0ZUBLsFgpOJZ68OAakz n3HgeG9nZ7raQB5J9DgE4FdwY8SAdh5TiDYPH/1LTKYL9W56wfEMrjYFvryF6hdbGRzn x+Ww== X-Forwarded-Encrypted: i=1; AJvYcCUKvhWqVCPuPoq8rHYxJpDUHodJov0s+N0XQwV4i0hXPVzaV6EOvm3cdzz4nJ/7X87RjOSM+9vJEUJdqtptncpB@lists.infradead.org, AJvYcCXnwbAcmBz2eTwfCivyjlAVl4yUt9dvU0/lZE48aDA4bjfjFT7VeTZgf1Tp3nM84bxEHZnz9hVXnM4Z@lists.infradead.org X-Gm-Message-State: AOJu0Yxf0XBzkMoQ/ZxAcM1Kuy+geSBQvS68IcBoxxhuKnRygk9prxJk AQA8+mELrXrfMRFVZQ2NeRgpYhSK1a9IvtMA1j+5l6tEhfGvp3DJTweRn+lkK69X X-Gm-Gg: ASbGncvovnDbhuDmDByB47N8LOmWgbpva2eT6J/GUMQ4kd8nJSPhyp/VGCTJO7PfnqD 3nTcinbFcjyfHJMvnVV0nS/dBTbUZKWiAkrfzz+O6J5Ci6StzNNEdA7bJbwRq9jNkQOj7183xmZ anXH8ax1SoUHkSL00V8RjCUfKazNylA0wuz8/yZC0KLNPJjzSg+CIdGOIAd2y+O32Rhj5to4DmG 6SNtYgoIhGBfv8khUBiQyxOvRy+oBkZu9FRIhOO0gVXL+5XY01+q0qO8IC3q2QAwb01RNi3BbNM yUdChI4a323N6fpKw/AQX4K9GGkVSGtU3D9ktD2EMOMBlAYhL1C+oLCi8n8G X-Google-Smtp-Source: AGHT+IGm/Jggfckdj6HI8cIvmve7CSJ/pB5QUFvBniX73YqNMzADesGHqX4F1bRZCdJ5ROCygqCy0g== X-Received: by 2002:a17:903:1c6:b0:235:e9fe:83c0 with SMTP id d9443c01a7336-237d9852f68mr72238635ad.27.1750470516535; Fri, 20 Jun 2025 18:48:36 -0700 (PDT) Received: from geday ([2804:7f2:800b:d1c8::dead:c001]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-237d8398dcbsm28491955ad.48.2025.06.20.18.48.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Jun 2025 18:48:36 -0700 (PDT) Date: Fri, 20 Jun 2025 22:48:30 -0300 From: Geraldo Nascimento To: linux-rockchip@lists.infradead.org Cc: Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , Vinod Koul , Kishon Vijay Abraham I , Rick wertenbroek , linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH v6 2/4] PCI: rockchip: Set Target Link Speed before retraining Message-ID: <0afa6bc47b7f50e2e81b0b47d51c66feb0fb565f.1750470187.git.geraldogabriel@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250620_184837_308568_83495832 X-CRM114-Status: UNSURE ( 9.66 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Current code may fail 5.0GT/s retraining if Target Link Speed is set to 2.5 GT/s in Link Control and Status Register 2. Set it to 5.0 GT/s accordingly. Tested-by: Robin Murphy Signed-off-by: Geraldo Nascimento --- drivers/pci/controller/pcie-rockchip-host.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/pci/controller/pcie-rockchip-host.c b/drivers/pci/controller/pcie-rockchip-host.c index 65653218b9ab..25890f6c0e17 100644 --- a/drivers/pci/controller/pcie-rockchip-host.c +++ b/drivers/pci/controller/pcie-rockchip-host.c @@ -341,6 +341,10 @@ static int rockchip_pcie_host_init_port(struct rockchip_pcie *rockchip) * Enable retrain for gen2. This should be configured only after * gen1 finished. */ + status = rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCTL2); + status &= ~PCI_EXP_LNKCTL2_TLS; + status |= PCI_EXP_LNKCTL2_TLS_5_0GT; + rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCTL2); status = rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCTL); status |= PCI_EXP_LNKCTL_RL; rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCTL); -- 2.49.0 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip