From mboxrd@z Thu Jan 1 00:00:00 1970 From: Romain Perier Subject: Re: [PATCH 1/4] ASoC: es8328-i2c: Add compatible for ES8388 Date: Mon, 16 Jan 2017 09:19:19 +0100 Message-ID: <0b359554-66ab-cb3c-7cca-3a46c1e4ad05@collabora.com> References: <20170113161452.14313-1-romain.perier@collabora.com> <20170113161452.14313-2-romain.perier@collabora.com> <3724319.rPxRAuBZBQ@phil> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <3724319.rPxRAuBZBQ@phil> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Heiko Stuebner Cc: Jaroslav Kysela , Takashi Iwai , alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Ian Campbell , Pawel Moll , Mark Rutland , Kumar Gala , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Sjoerd Simons List-Id: linux-rockchip.vger.kernel.org Hi Heiko, Le 13/01/2017 à 17:43, Heiko Stuebner a écrit : > Hi Romain, > > Am Freitag, 13. Januar 2017, 17:14:49 CET schrieb Romain Perier: >> This commit adds a compatible string for everest,es8388. This is >> an audio codec that is compatible with es8328. >> >> Signed-off-by: Romain Perier >> --- >> Documentation/devicetree/bindings/sound/es8328.txt | 2 +- >> sound/soc/codecs/es8328-i2c.c | 3 ++- >> 2 files changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/sound/es8328.txt >> b/Documentation/devicetree/bindings/sound/es8328.txt index 30ea8a3..33fbf05 >> 100644 >> --- a/Documentation/devicetree/bindings/sound/es8328.txt >> +++ b/Documentation/devicetree/bindings/sound/es8328.txt >> @@ -4,7 +4,7 @@ This device supports both I2C and SPI. >> >> Required properties: >> >> - - compatible : "everest,es8328" >> + - compatible : Should be "everest,es8328" or "everest,es8388" >> - DVDD-supply : Regulator providing digital core supply voltage 1.8 - >> 3.6V - AVDD-supply : Regulator providing analog supply voltage 3.3V >> - PVDD-supply : Regulator providing digital IO supply voltage 1.8 - 3.6V >> diff --git a/sound/soc/codecs/es8328-i2c.c b/sound/soc/codecs/es8328-i2c.c >> index 2d05b5d..09ae67f 100644 >> --- a/sound/soc/codecs/es8328-i2c.c >> +++ b/sound/soc/codecs/es8328-i2c.c >> @@ -19,13 +19,14 @@ >> #include "es8328.h" >> >> static const struct i2c_device_id es8328_id[] = { >> - { "es8328", 0 }, >> + { "es8328", "es8388", 0 }, > that looks strange or I'm just blind. > > struct i2c_device_id { > char name[I2C_NAME_SIZE]; > kernel_ulong_t driver_data; /* Data private to the driver */ > }; > > so shouldn't this be > > static const struct i2c_device_id es8328_id[] = { > { "es8328", 0 }, > + { "es8388", 0 }, > > instead? Good catch! thanks, Romain -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html