Re: [PATCH 1/4] ASoC: es8328-i2c: Add compatible for ES8388

Heiko Stuebner
2017-01-13T16:43:45Z

Hi Romain,

Am Freitag, 13. Januar 2017, 17:14:49 CET schrieb Romain Perier:
> This commit adds a compatible string for everest,es8388. This is
> an audio codec that is compatible with es8328.
>
> Signed-off-by: Romain Perier <romain.perier-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
> ---
> Documentation/devicetree/bindings/sound/es8328.txt | 2 +-
> sound/soc/codecs/es8328-i2c.c | 3 ++-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/es8328.txt
> b/Documentation/devicetree/bindings/sound/es8328.txt index 30ea8a3..33fbf05
> 100644
> --- a/Documentation/devicetree/bindings/sound/es8328.txt
> +++ b/Documentation/devicetree/bindings/sound/es8328.txt
> @@ -4,7 +4,7 @@ This device supports both I2C and SPI.
>
> Required properties:
>
> - - compatible : "everest,es8328"
> + - compatible : Should be "everest,es8328" or "everest,es8388"
> - DVDD-supply : Regulator providing digital core supply voltage 1.8 -
> 3.6V - AVDD-supply : Regulator providing analog supply voltage 3.3V
> - PVDD-supply : Regulator providing digital IO supply voltage 1.8 - 3.6V
> diff --git a/sound/soc/codecs/es8328-i2c.c b/sound/soc/codecs/es8328-i2c.c
> index 2d05b5d..09ae67f 100644
> --- a/sound/soc/codecs/es8328-i2c.c
> +++ b/sound/soc/codecs/es8328-i2c.c
> @@ -19,13 +19,14 @@
> #include "es8328.h"
>
> static const struct i2c_device_id es8328_id[] = {
> - { "es8328", 0 },
> + { "es8328", "es8388", 0 },

that looks strange or I'm just blind.

struct i2c_device_id {
char name[I2C_NAME_SIZE];
kernel_ulong_t driver_data; /* Data private to the driver */
};

so shouldn't this be

static const struct i2c_device_id es8328_id[] = {
{ "es8328", 0 },
+ { "es8388", 0 },

instead?

> { }
> };
> MODULE_DEVICE_TABLE(i2c, es8328_id);
>
> static const struct of_device_id es8328_of_match[] = {
> { .compatible = "everest,es8328", },
> + { .compatible = "everest,es8388", },
> { }
> };
> MODULE_DEVICE_TABLE(of, es8328_of_match);

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html