Linux-Rockchip Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Riesch <michael.riesch@collabora.com>
To: 楊智成 <jason98166@gmail.com>
Cc: Vinod Koul <vkoul@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Manivannan Sadhasivam <mani@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>,
	Guochun Huang <hero.huang@rock-chips.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Sebastian Reichel <sebastian.reichel@collabora.com>,
	Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	Sashiko <sashiko-bot@kernel.org>
Subject: Re: [PATCH v6 3/9] phy: rockchip-samsung-dcphy: Unwind power-on on PLL lock failure
Date: Mon, 16 Nov 2026 11:00:22 +0100	[thread overview]
Message-ID: <0d837fe2-e192-4fc6-a2e5-c23df40684ab@collabora.com> (raw)
In-Reply-To: <CAPwA33JHxsd=nr9F9_KFKWPx+HGaR8P3ee7hxMc8XCS6QY46gw@mail.gmail.com>

Hi Jason,

On 11/16/26 04:01, 楊智成 wrote:
> Hi Michael,
> 
> On 11/11/26 14:02, Michael Riesch wrote:
>> I wonder whether this should be here in the first place. Only judging by
>> the name, samsung_mipi_dcphy_pll_enable is something that affects the
>> complete logic block and probably should be kept in runtime resume to
>> begin with.
>>
>> However, since _dphy_rx_power_on does not call this funcion, it seems to
>> be something related only to the TX side of the logic block, but for
>> D-PHY and C-PHY. In this case, it probably should go into
>> samsung_mipi_dcphy_tx_power_on.
>>
>> On the off chance that this is actually for the D-PHY TX operation, the
>> function should be renamed "*_dcphy_pll_*" -> "*_dphy_pll_*" or
>> "*_dphy_tx_pll_*".
>>
>> What do you think?
> 
> The settings in this function are indeed only for TX, for both D-PHY
> and C-PHY, so I will rename the PLL helpers to
> samsung_mipi_dcphy_tx_pll_* in the renaming patch (6/9).
> 
> samsung_mipi_dcphy_tx_power_on does look like a more suitable place.
> However, I do not have a C-PHY board, and I only have one panel with
> mainline support, so I may not be able to test the DC-PHY TX side
> thoroughly. For now I am trying to leave the TX code unchanged unless
> my series affects that code.
> 
> Should I move the PLL enable to samsung_mipi_dcphy_tx_power_on, or keep
> this error cleanup path and the renaming change for now?

Thanks for the clarification.

I take it that the patch is only here because sashiko complained about
some existing bug. Your patch fixes this as-is, therefore

Reviewed-by: Michael Riesch <michael.riesch@collabora.com>

Still what we discussed makes sense, so let us do some refactoring in a
later series. I don't have any board with display either, but I think
Heiko and Quentin might have one for testing.

But again, let's focus on getting your patch series merged first.

Best regards,
Michael


> Thanks,
> Jason


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2026-11-16 10:01 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10  8:18 [PATCH v6 0/9] phy: rockchip-samsung-dcphy: Add the MIPI D-PHY receiver Jason Yang
2026-11-10  8:18 ` [PATCH v6 1/9] dt-bindings: phy: Add PHY_DIRECTION_TX/RX definitions Jason Yang
2026-11-11 10:29   ` Michael Riesch
2026-11-10  8:18 ` [PATCH v6 2/9] dt-bindings: phy: rockchip,rk3588-mipi-dcphy: Select TX or RX, add phy-type Jason Yang
2026-11-10 18:02   ` Rob Herring (Arm)
2026-11-11 10:33   ` Michael Riesch
2026-11-10  8:18 ` [PATCH v6 3/9] phy: rockchip-samsung-dcphy: Unwind power-on on PLL lock failure Jason Yang
2026-11-11 13:02   ` Michael Riesch
2026-11-16  3:01     ` 楊智成
2026-11-16 10:00       ` Michael Riesch [this message]
2026-11-10  8:18 ` [PATCH v6 4/9] phy: rockchip-samsung-dcphy: Always write the rate-dependent registers Jason Yang
2026-11-11 13:05   ` Michael Riesch
2026-11-10  8:18 ` [PATCH v6 5/9] phy: rockchip-samsung-dcphy: Move block-level setup to runtime resume Jason Yang
2026-11-11 13:14   ` Michael Riesch
2026-11-10  8:18 ` [PATCH v6 6/9] phy: rockchip-samsung-dcphy: Name the transmitter helpers and ops Jason Yang
2026-11-10  8:18 ` [PATCH v6 7/9] phy: rockchip-samsung-dcphy: Support the new phy-type and direction binding Jason Yang
2026-11-11 13:32   ` Michael Riesch
2026-11-10  8:18 ` [PATCH v6 8/9] phy: rockchip-samsung-dcphy: Add MIPI D-PHY receiver support Jason Yang
2026-11-11 15:22   ` Michael Riesch
2026-11-10  8:18 ` [PATCH v6 9/9] arm64: dts: rockchip: add the dcphy mipi csi-2 receiver nodes to rk3588 Jason Yang
2026-11-11 12:32   ` Michael Riesch
2026-11-13 11:08 ` [PATCH v6 0/9] phy: rockchip-samsung-dcphy: Add the MIPI D-PHY receiver Quentin Schulz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d837fe2-e192-4fc6-a2e5-c23df40684ab@collabora.com \
    --to=michael.riesch@collabora.com \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=hero.huang@rock-chips.com \
    --cc=jason98166@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mani@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=sashiko-bot@kernel.org \
    --cc=sebastian.reichel@collabora.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox