From: Nicolas Dufresne <nicolas.dufresne@collabora.com>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Benjamin Gaignard <benjamin.gaignard@collabora.com>,
ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de,
mchehab@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, heiko@sntech.de
Cc: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCH v6 12/13] media: verisilicon: Enable AV1 decoder on rk3588
Date: Wed, 12 Apr 2023 11:50:39 -0400 [thread overview]
Message-ID: <0dbdaef5940481b52ec33dacb6a1fe9ad4d0271c.camel@collabora.com> (raw)
In-Reply-To: <2f946887-6d4b-782b-d186-13b184207be3@xs4all.nl>
Le mercredi 12 avril 2023 à 14:43 +0200, Hans Verkuil a écrit :
> Hi Benjamin,
>
> On 12/04/2023 13:56, Benjamin Gaignard wrote:
> > Add rk3588 AV1 decoder to Hantro variant.
> > The hardware support image from 64x64 up to 7680x4320
> > by steps of 16 pixels.
> >
> > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
>
> Nicolas reviewed this patch in v5. Is there a reason that tag was dropped,
> or did you just forget? If it is the latter, then I can add it back.
>
>
I see that NV12_10LE40_4L4 is now NV15_4L4 as agreed, and don't see any other
changes.
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
>
> Just checking.
>
> This series now passes my tests.
>
> Regards,
>
> Hans
>
> > ---
> > .../media/platform/verisilicon/hantro_drv.c | 1 +
> > .../media/platform/verisilicon/hantro_hw.h | 6 +
> > .../platform/verisilicon/rockchip_vpu_hw.c | 134 ++++++++++++++++++
> > 3 files changed, 141 insertions(+)
> >
> > diff --git a/drivers/media/platform/verisilicon/hantro_drv.c b/drivers/media/platform/verisilicon/hantro_drv.c
> > index 71bd68e63859..aef1de20fc5e 100644
> > --- a/drivers/media/platform/verisilicon/hantro_drv.c
> > +++ b/drivers/media/platform/verisilicon/hantro_drv.c
> > @@ -713,6 +713,7 @@ static const struct of_device_id of_hantro_match[] = {
> > { .compatible = "rockchip,rk3399-vpu", .data = &rk3399_vpu_variant, },
> > { .compatible = "rockchip,rk3568-vepu", .data = &rk3568_vepu_variant, },
> > { .compatible = "rockchip,rk3568-vpu", .data = &rk3568_vpu_variant, },
> > + { .compatible = "rockchip,rk3588-av1-vpu", .data = &rk3588_vpu981_variant, },
> > #endif
> > #ifdef CONFIG_VIDEO_HANTRO_IMX8M
> > { .compatible = "nxp,imx8mm-vpu-g1", .data = &imx8mm_vpu_g1_variant, },
> > diff --git a/drivers/media/platform/verisilicon/hantro_hw.h b/drivers/media/platform/verisilicon/hantro_hw.h
> > index e3d303cea7f6..7f33f7b07ce4 100644
> > --- a/drivers/media/platform/verisilicon/hantro_hw.h
> > +++ b/drivers/media/platform/verisilicon/hantro_hw.h
> > @@ -403,11 +403,13 @@ extern const struct hantro_variant rk3328_vpu_variant;
> > extern const struct hantro_variant rk3399_vpu_variant;
> > extern const struct hantro_variant rk3568_vepu_variant;
> > extern const struct hantro_variant rk3568_vpu_variant;
> > +extern const struct hantro_variant rk3588_vpu981_variant;
> > extern const struct hantro_variant sama5d4_vdec_variant;
> > extern const struct hantro_variant sunxi_vpu_variant;
> >
> > extern const struct hantro_postproc_ops hantro_g1_postproc_ops;
> > extern const struct hantro_postproc_ops hantro_g2_postproc_ops;
> > +extern const struct hantro_postproc_ops rockchip_vpu981_postproc_ops;
> >
> > extern const u32 hantro_vp8_dec_mc_filter[8][6];
> >
> > @@ -444,6 +446,10 @@ void hantro_hevc_ref_init(struct hantro_ctx *ctx);
> > dma_addr_t hantro_hevc_get_ref_buf(struct hantro_ctx *ctx, s32 poc);
> > int hantro_hevc_add_ref_buf(struct hantro_ctx *ctx, int poc, dma_addr_t addr);
> >
> > +int rockchip_vpu981_av1_dec_init(struct hantro_ctx *ctx);
> > +void rockchip_vpu981_av1_dec_exit(struct hantro_ctx *ctx);
> > +int rockchip_vpu981_av1_dec_run(struct hantro_ctx *ctx);
> > +void rockchip_vpu981_av1_dec_done(struct hantro_ctx *ctx);
> >
> > static inline unsigned short hantro_vp9_num_sbs(unsigned short dimension)
> > {
> > diff --git a/drivers/media/platform/verisilicon/rockchip_vpu_hw.c b/drivers/media/platform/verisilicon/rockchip_vpu_hw.c
> > index 8de6fd2e8eef..816ffa905a4b 100644
> > --- a/drivers/media/platform/verisilicon/rockchip_vpu_hw.c
> > +++ b/drivers/media/platform/verisilicon/rockchip_vpu_hw.c
> > @@ -13,9 +13,13 @@
> > #include "hantro_g1_regs.h"
> > #include "hantro_h1_regs.h"
> > #include "rockchip_vpu2_regs.h"
> > +#include "rockchip_vpu981_regs.h"
> >
> > #define RK3066_ACLK_MAX_FREQ (300 * 1000 * 1000)
> > #define RK3288_ACLK_MAX_FREQ (400 * 1000 * 1000)
> > +#define RK3588_ACLK_MAX_FREQ (300 * 1000 * 1000)
> > +
> > +#define ROCKCHIP_VPU981_MIN_SIZE 64
> >
> > /*
> > * Supported formats.
> > @@ -74,6 +78,37 @@ static const struct hantro_fmt rockchip_vpu1_postproc_fmts[] = {
> > },
> > };
> >
> > +static const struct hantro_fmt rockchip_vpu981_postproc_fmts[] = {
> > + {
> > + .fourcc = V4L2_PIX_FMT_NV12,
> > + .codec_mode = HANTRO_MODE_NONE,
> > + .match_depth = true,
> > + .postprocessed = true,
> > + .frmsize = {
> > + .min_width = ROCKCHIP_VPU981_MIN_SIZE,
> > + .max_width = FMT_UHD_WIDTH,
> > + .step_width = MB_DIM,
> > + .min_height = ROCKCHIP_VPU981_MIN_SIZE,
> > + .max_height = FMT_UHD_HEIGHT,
> > + .step_height = MB_DIM,
> > + },
> > + },
> > + {
> > + .fourcc = V4L2_PIX_FMT_P010,
> > + .codec_mode = HANTRO_MODE_NONE,
> > + .match_depth = true,
> > + .postprocessed = true,
> > + .frmsize = {
> > + .min_width = ROCKCHIP_VPU981_MIN_SIZE,
> > + .max_width = FMT_UHD_WIDTH,
> > + .step_width = MB_DIM,
> > + .min_height = ROCKCHIP_VPU981_MIN_SIZE,
> > + .max_height = FMT_UHD_HEIGHT,
> > + .step_height = MB_DIM,
> > + },
> > + },
> > +};
> > +
> > static const struct hantro_fmt rk3066_vpu_dec_fmts[] = {
> > {
> > .fourcc = V4L2_PIX_FMT_NV12,
> > @@ -277,6 +312,48 @@ static const struct hantro_fmt rk3399_vpu_dec_fmts[] = {
> > },
> > };
> >
> > +static const struct hantro_fmt rockchip_vpu981_dec_fmts[] = {
> > + {
> > + .fourcc = V4L2_PIX_FMT_NV12_4L4,
> > + .codec_mode = HANTRO_MODE_NONE,
> > + .match_depth = true,
> > + .frmsize = {
> > + .min_width = ROCKCHIP_VPU981_MIN_SIZE,
> > + .max_width = FMT_UHD_WIDTH,
> > + .step_width = MB_DIM,
> > + .min_height = ROCKCHIP_VPU981_MIN_SIZE,
> > + .max_height = FMT_UHD_HEIGHT,
> > + .step_height = MB_DIM,
> > + },
> > + },
> > + {
> > + .fourcc = V4L2_PIX_FMT_NV15_4L4,
> > + .codec_mode = HANTRO_MODE_NONE,
> > + .match_depth = true,
> > + .frmsize = {
> > + .min_width = ROCKCHIP_VPU981_MIN_SIZE,
> > + .max_width = FMT_UHD_WIDTH,
> > + .step_width = MB_DIM,
> > + .min_height = ROCKCHIP_VPU981_MIN_SIZE,
> > + .max_height = FMT_UHD_HEIGHT,
> > + .step_height = MB_DIM,
> > + },
> > + },
> > + {
> > + .fourcc = V4L2_PIX_FMT_AV1_FRAME,
> > + .codec_mode = HANTRO_MODE_AV1_DEC,
> > + .max_depth = 2,
> > + .frmsize = {
> > + .min_width = ROCKCHIP_VPU981_MIN_SIZE,
> > + .max_width = FMT_UHD_WIDTH,
> > + .step_width = MB_DIM,
> > + .min_height = ROCKCHIP_VPU981_MIN_SIZE,
> > + .max_height = FMT_UHD_HEIGHT,
> > + .step_height = MB_DIM,
> > + },
> > + },
> > +};
> > +
> > static irqreturn_t rockchip_vpu1_vepu_irq(int irq, void *dev_id)
> > {
> > struct hantro_dev *vpu = dev_id;
> > @@ -331,6 +408,24 @@ static irqreturn_t rockchip_vpu2_vepu_irq(int irq, void *dev_id)
> > return IRQ_HANDLED;
> > }
> >
> > +static irqreturn_t rk3588_vpu981_irq(int irq, void *dev_id)
> > +{
> > + struct hantro_dev *vpu = dev_id;
> > + enum vb2_buffer_state state;
> > + u32 status;
> > +
> > + status = vdpu_read(vpu, AV1_REG_INTERRUPT);
> > + state = (status & AV1_REG_INTERRUPT_DEC_RDY_INT) ?
> > + VB2_BUF_STATE_DONE : VB2_BUF_STATE_ERROR;
> > +
> > + vdpu_write(vpu, 0, AV1_REG_INTERRUPT);
> > + vdpu_write(vpu, AV1_REG_CONFIG_DEC_CLK_GATE_E, AV1_REG_CONFIG);
> > +
> > + hantro_irq_done(vpu, state);
> > +
> > + return IRQ_HANDLED;
> > +}
> > +
> > static int rk3036_vpu_hw_init(struct hantro_dev *vpu)
> > {
> > /* Bump ACLK to max. possible freq. to improve performance. */
> > @@ -346,6 +441,13 @@ static int rk3066_vpu_hw_init(struct hantro_dev *vpu)
> > return 0;
> > }
> >
> > +static int rk3588_vpu981_hw_init(struct hantro_dev *vpu)
> > +{
> > + /* Bump ACLKs to max. possible freq. to improve performance. */
> > + clk_set_rate(vpu->clocks[0].clk, RK3588_ACLK_MAX_FREQ);
> > + return 0;
> > +}
> > +
> > static int rockchip_vpu_hw_init(struct hantro_dev *vpu)
> > {
> > /* Bump ACLK to max. possible freq. to improve performance. */
> > @@ -498,6 +600,14 @@ static const struct hantro_codec_ops rk3568_vepu_codec_ops[] = {
> > },
> > };
> >
> > +static const struct hantro_codec_ops rk3588_vpu981_codec_ops[] = {
> > + [HANTRO_MODE_AV1_DEC] = {
> > + .run = rockchip_vpu981_av1_dec_run,
> > + .init = rockchip_vpu981_av1_dec_init,
> > + .exit = rockchip_vpu981_av1_dec_exit,
> > + .done = rockchip_vpu981_av1_dec_done,
> > + },
> > +};
> > /*
> > * VPU variant.
> > */
> > @@ -529,10 +639,18 @@ static const char * const rk3066_vpu_clk_names[] = {
> > "aclk_vepu", "hclk_vepu"
> > };
> >
> > +static const struct hantro_irq rk3588_vpu981_irqs[] = {
> > + { "vdpu", rk3588_vpu981_irq },
> > +};
> > +
> > static const char * const rockchip_vpu_clk_names[] = {
> > "aclk", "hclk"
> > };
> >
> > +static const char * const rk3588_vpu981_vpu_clk_names[] = {
> > + "aclk", "hclk", "aclk_vdpu_root", "hclk_vdpu_root"
> > +};
> > +
> > /* VDPU1/VEPU1 */
> >
> > const struct hantro_variant rk3036_vpu_variant = {
> > @@ -678,3 +796,19 @@ const struct hantro_variant px30_vpu_variant = {
> > .clk_names = rockchip_vpu_clk_names,
> > .num_clocks = ARRAY_SIZE(rockchip_vpu_clk_names)
> > };
> > +
> > +const struct hantro_variant rk3588_vpu981_variant = {
> > + .dec_offset = 0x0,
> > + .dec_fmts = rockchip_vpu981_dec_fmts,
> > + .num_dec_fmts = ARRAY_SIZE(rockchip_vpu981_dec_fmts),
> > + .postproc_fmts = rockchip_vpu981_postproc_fmts,
> > + .num_postproc_fmts = ARRAY_SIZE(rockchip_vpu981_postproc_fmts),
> > + .postproc_ops = &rockchip_vpu981_postproc_ops,
> > + .codec = HANTRO_AV1_DECODER,
> > + .codec_ops = rk3588_vpu981_codec_ops,
> > + .irqs = rk3588_vpu981_irqs,
> > + .num_irqs = ARRAY_SIZE(rk3588_vpu981_irqs),
> > + .init = rk3588_vpu981_hw_init,
> > + .clk_names = rk3588_vpu981_vpu_clk_names,
> > + .num_clocks = ARRAY_SIZE(rk3588_vpu981_vpu_clk_names)
> > +};
>
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2023-04-12 15:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 11:56 [PATCH v6 00/13] AV1 stateless decoder for RK3588 Benjamin Gaignard
2023-04-12 11:56 ` [PATCH v6 01/13] dt-bindings: media: rockchip-vpu: Add rk3588 vpu compatible Benjamin Gaignard
2023-04-12 11:56 ` [PATCH v6 02/13] media: AV1: Make sure that bit depth in correctly initialize Benjamin Gaignard
2023-04-13 9:16 ` AngeloGioacchino Del Regno
2023-04-12 11:56 ` [PATCH v6 03/13] v4l2-common: Add support for fractional bpp Benjamin Gaignard
2023-04-12 11:56 ` [PATCH v6 04/13] media: Add NV15_4L4 pixel format Benjamin Gaignard
2023-04-12 11:56 ` [PATCH v6 05/13] media: verisilicon: Get bit depth for V4L2_PIX_FMT_NV15_4L4 Benjamin Gaignard
2023-04-13 9:16 ` AngeloGioacchino Del Regno
2023-04-12 11:56 ` [PATCH v6 06/13] media: verisilicon: Add AV1 decoder mode and controls Benjamin Gaignard
2023-04-13 9:16 ` AngeloGioacchino Del Regno
2023-04-12 11:56 ` [PATCH v6 07/13] media: verisilicon: Check AV1 bitstreams bit depth Benjamin Gaignard
2023-04-13 9:16 ` AngeloGioacchino Del Regno
2023-04-12 11:56 ` [PATCH v6 08/13] media: verisilicon: Compute motion vectors size for AV1 frames Benjamin Gaignard
2023-04-13 9:15 ` AngeloGioacchino Del Regno
2023-04-12 11:56 ` [PATCH v6 09/13] media: verisilicon: Add AV1 entropy helpers Benjamin Gaignard
2023-04-13 9:15 ` AngeloGioacchino Del Regno
2023-04-12 11:56 ` [PATCH v6 10/13] media: verisilicon: Add Rockchip AV1 decoder Benjamin Gaignard
2023-04-13 9:16 ` AngeloGioacchino Del Regno
2023-04-12 11:56 ` [PATCH v6 11/13] media: verisilicon: Add film grain feature to AV1 driver Benjamin Gaignard
2023-04-12 11:56 ` [PATCH v6 12/13] media: verisilicon: Enable AV1 decoder on rk3588 Benjamin Gaignard
2023-04-12 12:43 ` Hans Verkuil
2023-04-12 15:50 ` Nicolas Dufresne [this message]
2023-04-12 16:12 ` Benjamin Gaignard
2023-04-12 11:56 ` [PATCH v6 13/13] media: verisilicon: Conditionally ignore native formats Benjamin Gaignard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0dbdaef5940481b52ec33dacb6a1fe9ad4d0271c.camel@collabora.com \
--to=nicolas.dufresne@collabora.com \
--cc=benjamin.gaignard@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=heiko@sntech.de \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox