From: Robin Murphy <robin.murphy@arm.com>
To: Zhang Zekun <zhangzekun11@huawei.com>,
ezequiel@vanguardiasur.com.ar, mchehab@kernel.org,
gregkh@linuxfoundation.org, andrzej.p@collabora.com,
hverkuil-cisco@xs4all.nl
Cc: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] media: rkvdec: Fix memset size error
Date: Fri, 17 Jun 2022 09:10:57 +0100 [thread overview]
Message-ID: <107f5083-3545-770d-4d63-57c6829ef95a@arm.com> (raw)
In-Reply-To: <20220617073101.101234-1-zhangzekun11@huawei.com>
On 2022-06-17 08:31, Zhang Zekun wrote:
> 'dma_alloc_coherent()' alloc a 'RKVDEC_VP9_COUNT_SIZE' size area to
> 'unsigned char *count_tbl', however, the memset() bellow only set
> 'sizeof(*count_tbl)', which equals to 1, bytes to zero. This can
> cause unexpected error.
Have you observed an error in practice? Given that it's been part of the
dma_alloc_coherent() API to return a zeroed buffer for several years now
- see 750afb08ca71 ("cross-tree: phase out dma_zalloc_coherent()") -
this memset shouldn't be needed either way.
Robin.
> Fixes: f25709c4ff15 ("media: rkvdec: Add the VP9 backend")
> Signed-off-by: Zhang Zekun <zhangzekun11@huawei.com>
> ---
> drivers/staging/media/rkvdec/rkvdec-vp9.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/rkvdec/rkvdec-vp9.c b/drivers/staging/media/rkvdec/rkvdec-vp9.c
> index 311a12656072..3ad303a3de48 100644
> --- a/drivers/staging/media/rkvdec/rkvdec-vp9.c
> +++ b/drivers/staging/media/rkvdec/rkvdec-vp9.c
> @@ -1026,7 +1026,7 @@ static int rkvdec_vp9_start(struct rkvdec_ctx *ctx)
>
> vp9_ctx->count_tbl.size = RKVDEC_VP9_COUNT_SIZE;
> vp9_ctx->count_tbl.cpu = count_tbl;
> - memset(count_tbl, 0, sizeof(*count_tbl));
> + memset(count_tbl, 0, RKVDEC_VP9_COUNT_SIZE);
> rkvdec_init_v4l2_vp9_count_tbl(ctx);
>
> return 0;
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2022-06-17 8:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 7:31 [PATCH -next] media: rkvdec: Fix memset size error Zhang Zekun
2022-06-17 8:10 ` Robin Murphy [this message]
2022-06-20 7:52 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=107f5083-3545-770d-4d63-57c6829ef95a@arm.com \
--to=robin.murphy@arm.com \
--cc=andrzej.p@collabora.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=zhangzekun11@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox