* [PATCH] arm64: dts: rockchip: fix sdmmc detection on boot
@ 2019-10-16 18:59 Peter Geis
[not found] ` <20191016185945.1962-1-pgwipeout-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Peter Geis @ 2019-10-16 18:59 UTC (permalink / raw)
To: heiko-4mtYJXux2i+zQB+pC5nmwQ
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Peter Geis
With working GPIO, during init the GPIO state s reset.
This causes the sdmmc regulator to shut down, preventing detection.
Removing and replacing the card will allow it to be detected, but that should not be necessary.
Fix this by setting the regulator on at boot.
Signed-off-by: Peter Geis <pgwipeout-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts b/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts
index bb40c163b05d..8d553c92182a 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts
@@ -35,6 +35,7 @@
gpio = <&gpio0 RK_PD6 GPIO_ACTIVE_LOW>;
pinctrl-names = "default";
pinctrl-0 = <&sdmmc0m1_gpio>;
+ regulator-boot-on;
regulator-name = "vcc_sd";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: fix sdmmc detection on boot
[not found] ` <20191016185945.1962-1-pgwipeout-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2019-11-09 1:16 ` Heiko Stuebner
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stuebner @ 2019-11-09 1:16 UTC (permalink / raw)
To: Peter Geis; +Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Am Mittwoch, 16. Oktober 2019, 20:59:46 CET schrieb Peter Geis:
> With working GPIO, during init the GPIO state s reset.
> This causes the sdmmc regulator to shut down, preventing detection.
> Removing and replacing the card will allow it to be detected, but that should not be necessary.
> Fix this by setting the regulator on at boot.
>
> Signed-off-by: Peter Geis <pgwipeout-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
applied for 5.5
Thanks
Heiko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-09 1:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-16 18:59 [PATCH] arm64: dts: rockchip: fix sdmmc detection on boot Peter Geis
[not found] ` <20191016185945.1962-1-pgwipeout-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-11-09 1:16 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).