Re: [PATCH 3/7] pinctrl: rockchip: Add support for RK3528

Jonas Karlman
2025-03-17T08:03:49Z

Hi Chukun,

On 2025-03-17 08:00, Chukun Pan wrote:
> Hi,
>
>> Add gpio and pinctrl support for the 5 GPIO banks on RK3528.
>
> https://source.denx.de/u-boot/contributors/kwiboo/u-boot/-/blob/rk3528/drivers/pinctrl/rockchip/pinctrl-rk3528.c#L204-L207
>
> I noticed that there is a little difference between u-boot and kernel
> pinctrl driver. Does kernel need to sync this changes from u-boot?

RK3568_SCHMITT_BITS_PER_PIN is defined as 2 and RK3528_SMT_BITS_PER_PIN
as 1 so I think this code is correct, however I can probably update the
U-Boot code to use similar pattern as in Linux driver before sending a
new revision of the U-Boot series (probably after v6.15-rc1-dts).

Regards,
Jonas

>
> ```
> diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
> index 930c454e0cec..c77d9a6cd535 100644
> --- a/drivers/pinctrl/pinctrl-rockchip.c
> +++ b/drivers/pinctrl/pinctrl-rockchip.c
> @@ -3070,6 +3070,7 @@ static int rockchip_get_schmitt(struct rockchip_pin_bank *bank, int pin_num)
>
> data >>= bit;
> switch (ctrl->type) {
> + case RK3528:
> case RK3562:
> case RK3568:
> return data & ((1 << RK3568_SCHMITT_BITS_PER_PIN) - 1);
> @@ -3100,6 +3101,7 @@ static int rockchip_set_schmitt(struct rockchip_pin_bank *bank,
>
> /* enable the write to the equivalent lower bits */
> switch (ctrl->type) {
> + case RK3528:
> case RK3562:
> case RK3568:
> data = ((1 << RK3568_SCHMITT_BITS_PER_PIN) - 1) << (bit + 16);
> ```
>
> Thanks,
> Chukun
>
> --
> 2.25.1