From: <Tudor.Ambarus@microchip.com>
To: <patrice.chotard@foss.st.com>, <Sergiu.Moga@microchip.com>,
<pratyush@kernel.org>, <michael@walle.cc>,
<miquel.raynal@bootlin.com>, <richard@nod.at>, <vigneshr@ti.com>,
<broonie@kernel.org>, <Nicolas.Ferre@microchip.com>,
<alexandre.belloni@bootlin.com>, <Claudiu.Beznea@microchip.com>,
<chin-ting_kuo@aspeedtech.com>, <clg@kaod.org>, <joel@jms.id.au>,
<andrew@aj.id.au>, <kdasu.kdev@gmail.com>,
<fancer.lancer@gmail.com>, <han.xu@nxp.com>,
<john.garry@huawei.com>, <matthias.bgg@gmail.com>,
<avifishman70@gmail.com>, <tmaimon77@gmail.com>,
<tali.perry1@gmail.com>, <venture@google.com>, <yuenn@google.com>,
<benjaminfair@google.com>, <haibo.chen@nxp.com>,
<yogeshgaur.83@gmail.com>, <heiko@sntech.de>,
<mcoquelin.stm32@gmail.com>, <alexandre.torgue@foss.st.com>,
<michal.simek@xilinx.com>
Cc: <bcm-kernel-feedback-list@broadcom.com>,
<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
<linux-spi@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-aspeed@lists.ozlabs.org>, <openbmc@lists.ozlabs.org>,
<linux-mediatek@lists.infradead.org>,
<linux-rockchip@lists.infradead.org>,
<linux-stm32@st-md-mailman.stormreply.com>
Subject: Re: [PATCH] spi: Replace `dummy.nbytes` with `dummy.ncycles`
Date: Mon, 12 Sep 2022 10:58:10 +0000 [thread overview]
Message-ID: <118c2b49-fefd-7de6-5b0f-9ae4064c7b56@microchip.com> (raw)
In-Reply-To: <2c44a497-b489-7519-e922-4ec79eb7617d@foss.st.com>
On 9/12/22 12:44, Patrice CHOTARD wrote:
Hi!
>> - /* 2 bytes per clock cycle in DTR mode. */
>> - op->dummy.nbytes *= 2;
>> -
> What is the benefit to remove dtr dummy.nbytes computation ? it leads to spray it in all drivers which support DTR.
> It was simpler to let the framework to deal with it, have i missed something ?
The majority of drivers from SPI need the number of cycles, not the number
of bytes. JESD216 refers to dummy ncycles as well, there's no such thing as
dummy nbytes. You'll notice that these drivers do the computation back to
ncycles in their driver, thus they undo what's prepared in SPI NOR. There
are just 4 drivers that use nbytes and rely on what's currently computed in
SPI NOR. Since these 4 drivers don't use the standard parameter and require
nbytes instead, they can do the conversion to nbytes in their driver.
--
Cheers,
ta
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2022-09-12 11:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-11 17:45 [PATCH] spi: Replace `dummy.nbytes` with `dummy.ncycles` Sergiu Moga
2022-09-12 9:44 ` Patrice CHOTARD
2022-09-12 10:58 ` Tudor.Ambarus [this message]
2022-09-12 11:52 ` Mark Brown
2022-09-25 22:03 ` Serge Semin
2022-09-26 9:05 ` Sergiu.Moga
2022-09-26 17:24 ` Serge Semin
2022-09-27 8:21 ` Sergiu.Moga
2023-03-08 9:04 ` Tudor Ambarus
2023-03-09 8:38 ` Michael Walle
2023-03-09 10:42 ` Tudor Ambarus
2023-03-09 10:56 ` Michael Walle
2023-03-09 12:09 ` Tudor Ambarus
2023-03-09 12:35 ` Michael Walle
2023-03-09 13:23 ` Tudor Ambarus
2023-03-09 13:33 ` Michael Walle
2023-03-09 13:54 ` Tudor Ambarus
2023-03-09 14:01 ` Michael Walle
2023-03-09 14:19 ` Chuanhong Guo
2023-03-09 15:41 ` Michael Walle
2023-03-09 15:41 ` Tudor Ambarus
2023-03-04 5:59 ` Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=118c2b49-fefd-7de6-5b0f-9ae4064c7b56@microchip.com \
--to=tudor.ambarus@microchip.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=Sergiu.Moga@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew@aj.id.au \
--cc=avifishman70@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=benjaminfair@google.com \
--cc=broonie@kernel.org \
--cc=chin-ting_kuo@aspeedtech.com \
--cc=clg@kaod.org \
--cc=fancer.lancer@gmail.com \
--cc=haibo.chen@nxp.com \
--cc=han.xu@nxp.com \
--cc=heiko@sntech.de \
--cc=joel@jms.id.au \
--cc=john.garry@huawei.com \
--cc=kdasu.kdev@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=michael@walle.cc \
--cc=michal.simek@xilinx.com \
--cc=miquel.raynal@bootlin.com \
--cc=openbmc@lists.ozlabs.org \
--cc=patrice.chotard@foss.st.com \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=vigneshr@ti.com \
--cc=yogeshgaur.83@gmail.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox