From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Brian Norris <briannorris@chromium.org>
Cc: mark.rutland@arm.com, Doug Anderson <dianders@chromium.org>,
linux-rockchip@lists.infradead.org,
David Airlie <airlied@linux.ie>,
zyw@rock-chips.com, hoegsberg@gmail.com,
Philippe Cornu <philippe.cornu@st.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Yannick Fertre <yannick.fertre@st.com>,
Nickey Yang <nickey.yang@rock-chips.com>,
mka@chromium.org, robh+dt@kernel.org, xbl@rock-chips.com,
Vincent Abriou <vincent.abriou@st.com>,
hl@rock-chips.com
Subject: Re: [PATCH v4] arm64: dts: rockchip: update mipi cells for RK3399
Date: Mon, 04 Dec 2017 15:22:07 +0200 [thread overview]
Message-ID: <13507001.EQOuo8KY2k@avalon> (raw)
In-Reply-To: <20171129184755.77187-1-briannorris@chromium.org>
Hi Nickey,
Thank you for the patch.
On Wednesday, 29 November 2017 20:47:55 EET Brian Norris wrote:
> From: Nickey Yang <nickey.yang@rock-chips.com>
>
> We might include additional ports in derivative device trees, so the
> 'port' node should have an address, and the parent 'ports' node needs
> /#{addres,size}-cells.
>
> v4:
> * keep #{address,size}-cells in both 'ports' and 'port@0' nodes
> * separate from the rest of the series, since this is mostly
> independent of the driver refactoring
>
> Signed-off-by: Nickey Yang <nickey.yang@rock-chips.com>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index d340b58ab184..c6dae25a3f23
> 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -1652,7 +1652,11 @@
> status = "disabled";
>
> ports {
> - mipi_in: port {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + mipi_in: port@0 {
> + reg = <0>;
> #address-cells = <1>;
> #size-cells = <0>;
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-12-04 13:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 18:47 [PATCH v4] arm64: dts: rockchip: update mipi cells for RK3399 Brian Norris
2017-11-29 20:52 ` Doug Anderson
2017-12-04 10:05 ` Heiko Stuebner
2017-12-04 13:22 ` Laurent Pinchart [this message]
2017-12-04 13:46 ` Heiko Stuebner
2017-12-04 16:36 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13507001.EQOuo8KY2k@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=briannorris@chromium.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hl@rock-chips.com \
--cc=hoegsberg@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mka@chromium.org \
--cc=nickey.yang@rock-chips.com \
--cc=philippe.cornu@st.com \
--cc=robh+dt@kernel.org \
--cc=vincent.abriou@st.com \
--cc=xbl@rock-chips.com \
--cc=yannick.fertre@st.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox