From: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
To: Javier Martinez Canillas <javier@osg.samsung.com>,
linux-rockchip@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org,
Heiko Stuebner <heiko@sntech.de>, Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Thierry Reding <treding@nvidia.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
linux-kernel@vger.kernel.org,
Russell King <linux@arm.linux.org.uk>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Arnd Bergmann <arnd@arndb.de>, Lee Jones <lee.jones@linaro.org>,
Olof Johansson <olof@lixom.net>, Ray Jui <rjui@broadcom.com>,
Stephen Warren <swarren@nvidia.com>
Subject: Re: [PATCH 1/4] ARM: multi_v7_defconfig: Enable common Rockchip devices/busses
Date: Mon, 07 Sep 2015 12:24:27 +0200 [thread overview]
Message-ID: <1441621467.8778.26.camel@collabora.co.uk> (raw)
In-Reply-To: <55ED585B.9030009@osg.samsung.com>
On Mon, 2015-09-07 at 11:26 +0200, Javier Martinez Canillas wrote:
> Hello Sjoerd,
>
> On 09/06/2015 10:16 PM, Sjoerd Simons wrote:
> > Enable Rockchip I2C, SPI, PWM, thermal drivers.
> >
> > Builtin are:
> > * I2C as it often controls the pmic.
>
> Having I2C as a module will cause more probe deferrals due missing
> regulators and slow down the boot but it should not cause issues.
> Or am I missing something?
>
> In fact, I think even the PMIC could be built as a module.
It could in principle. However as a lot of other drivers do need the
regulators provided by the pmic, they'll be deferred until that driver
is loaded. So e.g. with the i2c/pmic drivers as a module you cannot
boot to an NFS rootfs without using an initramfs.
> But I don't have a strong opinion on this so patch looks good:
>
> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> Best regards,
--
Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Collabora Ltd.
next prev parent reply other threads:[~2015-09-07 10:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-06 20:16 [PATCH 0/4] ARM: multi_v7_defconfig: Improve rockchip support Sjoerd Simons
[not found] ` <1441570566-14001-1-git-send-email-sjoerd.simons-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2015-09-06 20:16 ` [PATCH 1/4] ARM: multi_v7_defconfig: Enable common Rockchip devices/busses Sjoerd Simons
2015-09-07 9:26 ` Javier Martinez Canillas
2015-09-07 10:24 ` Sjoerd Simons [this message]
2015-09-07 10:38 ` Javier Martinez Canillas
2015-09-07 11:27 ` Thierry Reding
2015-09-07 10:55 ` Andy Yan
2015-09-07 11:06 ` Javier Martinez Canillas
2015-09-06 20:16 ` [PATCH 2/4] ARM: multi_v7_defconfig: Enable ACT8865 PMIC driver Sjoerd Simons
2015-09-07 9:30 ` Javier Martinez Canillas
[not found] ` <1441570566-14001-3-git-send-email-sjoerd.simons-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2015-09-07 9:33 ` Heiko Stübner
2015-09-07 10:49 ` Andy Yan
2015-09-07 10:53 ` Heiko Stübner
2015-09-06 20:16 ` [PATCH 4/4] ARM: multi_v7_defconfig: Enable DW USB2 support and rockchip phy Sjoerd Simons
2015-09-07 0:02 ` Krzysztof Kozlowski
2015-09-07 7:10 ` Sjoerd Simons
2015-09-07 7:24 ` Krzysztof Kozlowski
[not found] ` <55ED3BC5.8050603-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-09-07 7:53 ` Heiko Stübner
2015-09-07 7:56 ` Krzysztof Kozlowski
2015-09-07 8:49 ` Sjoerd Simons
2015-09-07 9:33 ` Javier Martinez Canillas
2015-09-06 20:16 ` [PATCH 3/4] ARM: multi_v7_defconfig: Enable Rockchip display support Sjoerd Simons
2015-09-07 9:31 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441621467.8778.26.camel@collabora.co.uk \
--to=sjoerd.simons@collabora.co.uk \
--cc=alexandre.belloni@free-electrons.com \
--cc=arnd@arndb.de \
--cc=geert+renesas@glider.be \
--cc=heiko@sntech.de \
--cc=javier@osg.samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=olof@lixom.net \
--cc=rjui@broadcom.com \
--cc=swarren@nvidia.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox