Re: [PATCH v6] i2c: rk3x: add i2c support for rk3399 soc

Doug Anderson
2016-04-28T21:28:34Z

Hi,

On Thu, Apr 28, 2016 at 6:39 AM, David.Wu <david.wu@rock-chips.com> wrote:
> +enum rk3x_i2c_bus_speed {
> + I2C_FS_SPD,
> + I2C_HS_SPD
> +};
> +
> +struct rk3x_i2c;
>
> Why do you need this forward definition? Seems like it's not
> necessary. Remove?
>
>
> I think we need a Master_Code state to seperate from other state.

I meant remove the line above the contains just:

struct rk3x_i2c;

...I don't believe it's needed. You only need a forward declaration
like that if you refer to the structure before it's defined.

-Doug