public inbox for linux-rockchip@lists.infradead.org
 help / color / mirror / Atom feed
From: Caesar Wang <wxt@rock-chips.com>
To: edubezval@gmail.com
Cc: Heiko Stuebner <heiko@sntech.de>,
	dianders@chromium.org, briannorris@google.com,
	smbarber@google.com, linux-rockchip@lists.infradead.org,
	cf@rock-chips.com, huangtao@rock-chips.com,
	dmitry.torokhov@gmail.com, Sascha Hauer <s.hauer@pengutronix.de>,
	Caesar Wang <wxt@rock-chips.com>, Zhang Rui <rui.zhang@intel.com>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 4/5] thermal: bang-bang governor: act on lower trip boundary
Date: Tue,  3 May 2016 17:33:32 +0800	[thread overview]
Message-ID: <1462268013-14992-5-git-send-email-wxt@rock-chips.com> (raw)
In-Reply-To: <1462268013-14992-1-git-send-email-wxt@rock-chips.com>

From: Sascha Hauer <s.hauer@pengutronix.de>

With interrupt driven thermal zones we pass the lower and upper
temperature on which shall be acted, so in the governor we have to act on
the exact lower temperature to be consistent. Otherwise an interrupt maybe
generated on the exact lower temperature, but the bang bang governor does
not react since The polling driven zones have to be one step cooler before
the governor reacts.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Caesar Wang <wxt@rock-chips.com>
Cc: Zhang Rui <rui.zhang@intel.com>
Cc: Eduardo Valentin <edubezval@gmail.com>
Cc: linux-pm@vger.kernel.org

---

Changes in v2:
- Update the commit for patch[v2 4/5].

 drivers/thermal/gov_bang_bang.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/gov_bang_bang.c b/drivers/thermal/gov_bang_bang.c
index 70836c5..9d1dfea 100644
--- a/drivers/thermal/gov_bang_bang.c
+++ b/drivers/thermal/gov_bang_bang.c
@@ -59,7 +59,7 @@ static void thermal_zone_trip_update(struct thermal_zone_device *tz, int trip)
 		if (instance->target == 0 && tz->temperature >= trip_temp)
 			instance->target = 1;
 		else if (instance->target == 1 &&
-				tz->temperature < trip_temp - trip_hyst)
+				tz->temperature <= trip_temp - trip_hyst)
 			instance->target = 0;
 
 		dev_dbg(&instance->cdev->device, "target=%d\n",
-- 
1.9.1

  parent reply	other threads:[~2016-05-03  9:33 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-03  9:33 [PATCH v2 0/5] Thermal: Support for hardware-tracked trip points Caesar Wang
     [not found] ` <1462268013-14992-1-git-send-email-wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-05-03  9:33   ` [PATCH v2 1/5] thermal: Add support " Caesar Wang
2016-05-24 12:57     ` Javi Merino
2016-05-25  3:27       ` Caesar Wang
2016-05-25 16:44         ` Javi Merino
2016-05-03  9:33 ` [PATCH v2 2/5] thermal: of: implement .set_trips for device tree thermal zones Caesar Wang
2016-05-24 13:01   ` Javi Merino
2016-05-25  3:28     ` Caesar Wang
2016-05-03  9:33 ` [PATCH v2 3/5] thermal: streamline get_trend callbacks Caesar Wang
2016-05-03  9:33 ` Caesar Wang [this message]
2016-05-24 13:06   ` [PATCH v2 4/5] thermal: bang-bang governor: act on lower trip boundary Javi Merino
2016-05-24 13:11     ` Peter Feuerer
2016-05-24 17:34     ` Peter Feuerer
     [not found]       ` <a942e788aa285dcf88db38c6d03a36ce-wZNyVc2rXxoqcZcGjlUOXw@public.gmane.org>
2016-05-25  3:30         ` Caesar Wang
2016-05-03  9:33 ` [PATCH v2 5/5] thermal: rockchip: add the set_trips function Caesar Wang
2016-05-23  7:32 ` [PATCH v2 0/5] Thermal: Support for hardware-tracked trip points Caesar Wang
2016-05-24  3:08   ` Eduardo Valentin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1462268013-14992-5-git-send-email-wxt@rock-chips.com \
    --to=wxt@rock-chips.com \
    --cc=briannorris@google.com \
    --cc=cf@rock-chips.com \
    --cc=dianders@chromium.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=edubezval@gmail.com \
    --cc=heiko@sntech.de \
    --cc=huangtao@rock-chips.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=rui.zhang@intel.com \
    --cc=s.hauer@pengutronix.de \
    --cc=smbarber@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox