Re: [PATCH v2 05/10] drm/rockchip: analogix_dp: add rk3399 eDP support

Doug Anderson
2016-05-24T18:12:20Z

Hi,

On Tue, May 24, 2016 at 3:17 AM, Heiko Stuebner <heiko@sntech.de> wrote:
>> --- a/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt
>> +++ b/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt
>> @@ -5,6 +5,7 @@ Required properties for dp-controller:
>> platform specific such as:
>> * "samsung,exynos5-dp"
>> * "rockchip,rk3288-dp"
>> + * "rockchip,rk3399-edp"
>
> the cleanlines-freak in my likes to know if there is a difference between
> the rk3399 being called -edp here and -dp on the rk3288 :-)
>
> [...]

If I was a guessing man (which I'm not, but if I was), I'd guess that
this is because on rk3288 there was only one DP port and it was an EDP
port. ...but since there was only one people just referred to it as
the "DP" port and that was codified in the bindings. On rk3399 there
are two ports: one EDP and one DP. All of a sudden we need to
differentiate.

Any better suggestions for how to deal with that?

-Doug