From: Caesar Wang <wxt@rock-chips.com>
To: daniel.lezcano@linaro.org, Heiko Stuebner <heiko@sntech.de>
Cc: dianders@chromium.org, briannorris@google.com,
smbarber@google.com, linux-rockchip@lists.infradead.org,
Thomas Gleixner <tglx@linutronix.de>,
cf@rock-chips.com, huangtao@rock-chips.com,
Caesar Wang <wxt@rock-chips.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/4] clocksource: rockchip: add dynamic irq flag to the timer
Date: Tue, 7 Jun 2016 12:54:31 +0800 [thread overview]
Message-ID: <1465275273-22076-3-git-send-email-wxt@rock-chips.com> (raw)
In-Reply-To: <1465275273-22076-1-git-send-email-wxt@rock-chips.com>
From: "Huang, Tao" <huangtao@rock-chips.com>
The rockchip timer is broadcast timer. Add CLOCK_EVT_FEAT_DYNIRQ
flag and set cpumask to all possible cpus to save power by avoid
unnecessary wakeups and IPIs.
Signed-off-by: Huang Tao <huangtao@rock-chips.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Heiko Stuebner <heiko@sntech.de>
Tested-by: Jianqun Xu <jay.xu@rock-chips.com>
Signed-off-by: Caesar Wang <wxt@rock-chips.com>
---
Changes in v2:
- s/cpu_all_mask/cpu_possible_mask/, As Daniel comments on
https://patchwork.kernel.org/patch/9135053/.
drivers/clocksource/rockchip_timer.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/clocksource/rockchip_timer.c b/drivers/clocksource/rockchip_timer.c
index b991b28..b510863 100644
--- a/drivers/clocksource/rockchip_timer.c
+++ b/drivers/clocksource/rockchip_timer.c
@@ -150,12 +150,13 @@ static void __init rk_timer_init(struct device_node *np)
}
ce->name = TIMER_NAME;
- ce->features = CLOCK_EVT_FEAT_PERIODIC | CLOCK_EVT_FEAT_ONESHOT;
+ ce->features = CLOCK_EVT_FEAT_PERIODIC | CLOCK_EVT_FEAT_ONESHOT |
+ CLOCK_EVT_FEAT_DYNIRQ;
ce->set_next_event = rk_timer_set_next_event;
ce->set_state_shutdown = rk_timer_shutdown;
ce->set_state_periodic = rk_timer_set_periodic;
ce->irq = irq;
- ce->cpumask = cpumask_of(0);
+ ce->cpumask = cpu_possible_mask;
ce->rating = 250;
rk_timer_interrupt_clear(ce);
--
1.9.1
next prev parent reply other threads:[~2016-06-07 4:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 4:54 [PATCH v2 0/4] clocksource: rockchip/timer: Support rktimer for rk3399 Caesar Wang
2016-06-07 4:54 ` [PATCH v2 1/4] dt-bindings: document rk3399 rk-timer bindings Caesar Wang
2016-06-07 4:54 ` Caesar Wang [this message]
2016-06-07 4:54 ` [PATCH v2 3/4] clocksource: rockchip: add support for rk3399 SoC Caesar Wang
2016-06-07 4:54 ` [PATCH v2 4/4] arm64: dts: rockchip: add rktimer device node for rk3399 Caesar Wang
[not found] ` <1465275273-22076-1-git-send-email-wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-06-13 13:06 ` [PATCH v2 0/4] clocksource: rockchip/timer: Support rktimer " Daniel Lezcano
2016-06-14 4:00 ` Huang, Tao
2016-06-14 9:12 ` Caesar Wang
2016-06-16 14:26 ` Daniel Lezcano
2016-06-17 1:08 ` Caesar Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465275273-22076-3-git-send-email-wxt@rock-chips.com \
--to=wxt@rock-chips.com \
--cc=briannorris@google.com \
--cc=cf@rock-chips.com \
--cc=daniel.lezcano@linaro.org \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=smbarber@google.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox