Re: [PATCH v3 2/3] dt-bindings: phy: add DT bindings for usb2-phy grf

Heiko Stübner
2017-03-06T03:59:44Z

Am Montag, 6. März 2017, 09:29:37 CET schrieb Meng Dongyang:
> Adds the device tree bindings description for usb2-phy grf
> of RK3328 platform.
>
> Changes in v2:
> - add usb2-phy grf specification
> Chagnes in v3:
> - remove the example of usb2-phy grf
>
> Signed-off-by: Meng Dongyang <daniel.meng-TNX95d0MmH7DzftRWevZcw@public.gmane.org>

looks good now,

Reviewed-by: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>

> ---
> Documentation/devicetree/bindings/soc/rockchip/grf.txt | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/soc/rockchip/grf.txt
> b/Documentation/devicetree/bindings/soc/rockchip/grf.txt index
> 013e71a..af5b44d 100644
> --- a/Documentation/devicetree/bindings/soc/rockchip/grf.txt
> +++ b/Documentation/devicetree/bindings/soc/rockchip/grf.txt
> @@ -7,6 +7,8 @@ From RK3368 SoCs, the GRF is divided into two sections,
> - GRF, used for general non-secure system,
> - PMUGRF, used for always on system
>
> +On RK3328 SoCs, the GRF adds a section for USB2PHYGRF,
> +
> Required Properties:
>
> - compatible: GRF should be one of the followings
> @@ -19,6 +21,8 @@ Required Properties:
> - compatible: PMUGRF should be one of the followings
> - "rockchip,rk3368-pmugrf", "syscon": for rk3368
> - "rockchip,rk3399-pmugrf", "syscon": for rk3399
> +- compatible: USB2PHYGRF should be one of the followings
> + - "rockchip,rk3328-usb2phy-grf", "syscon": for rk3328
> - reg: physical base address of the controller and length of memory mapped
> region.