From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A51DCCF9E5 for ; Mon, 27 Oct 2025 12:39:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tn3ZCWllTrqgdU1FceWW6PMuNgud2PUGm8Z/ZINrRYc=; b=q0zco2eE8vte4C ueGD2VXHdUGe2/Ng2oCQ82GU7ke9uN7niy+eoMP8bhKyYgRlwVjmB5jAhKStRps+3TDE1YxHA1R1B q55rGIQXeBgqxXYewBDssSCsPAfj73h6OcySd6XbsgEVzA/3jgtRP93y5nHH8UZ/WgVKiVRNOaVI4 Gwg1Scp7BtyorvXwfVCLPkkiNp5QkVskm5CjK81wfi3Vz2c4Ck+0wtPCB4TEqYpxXmpxkEE+Tlcas 4cSe4z8HCq6oSf2vBEmYrk2S26Kj0NZqKdsNMJd3e3QRr+0ThaB2ugjJxiTg+RqEXrDJJmuDn5asM RkLb+ObS7Vf8hPCbmj9A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vDMVC-0000000Dupt-3d8c; Mon, 27 Oct 2025 12:39:10 +0000 Received: from bali.collaboradmins.com ([148.251.105.195]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vDMVA-0000000Dunp-0BPf; Mon, 27 Oct 2025 12:39:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1761568743; bh=ic23nmo9lgfOG3Z3HGilbKWoY/RcEgbzf3VPutvzob4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=N6vRJVhaiEkHsez1pDm7qCVveefUoUXgEwiGf0Hxl/Jf0HRoQKn9Iz+MbCPsaNHi+ T5w/5RNIA0FQL4WRZ+dafcRIwodzJtXuHu1V1EWkoea7alkWmyfDnPF/00R6D4AuFo qkZlGaWVPQOQVfrq85FPJtr4ARCt5g7hMvVo8vJ5aG+vokYy47F4V+SVwWQiwGBQOX 8LyTUKxSk9RxiOXVfCjlJaHDVz8cU/2Yx5PO0dQmI0xcKalAaieCzpcfdSWJcKIOgo 2l8VGGa6BttkTBLzoa4bOgekD2KXUpRrSikDo5xQrJ6MEDinPsIgiVu5DJ0KNlrP8v ggOd7pxr9D1hg== Received: from [10.40.0.100] (185-67-175-126.lampert.tv [185.67.175.126]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mriesch) by bali.collaboradmins.com (Postfix) with ESMTPSA id 6B23017E0927; Mon, 27 Oct 2025 13:39:03 +0100 (CET) Message-ID: <1499f50e-aa4f-454a-b8b5-c9a21bef7f72@collabora.com> Date: Mon, 27 Oct 2025 13:39:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: rockchip: orangepi-5: fix PCIe 3.3V regulator voltage To: Mykola Kvach , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Cenk Uluisik , Johan Jonker Cc: Jimmy Hon , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Muhammed Efe Cetin References: <20251024173830.49211-1-xakep.amatop@gmail.com> Content-Language: en-US From: Michael Riesch In-Reply-To: <20251024173830.49211-1-xakep.amatop@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251027_053908_266876_8525C604 X-CRM114-Status: GOOD ( 15.88 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hi Mykola, Thanks for your patch. Cc: Muhammed who is the author of commit b6bc755d806e On 10/24/25 19:38, Mykola Kvach wrote: > The vcc3v3_pcie20 fixed regulator powers the PCIe device-side 3.3V > rail for pcie2x1l2 via vpcie3v3-supply. The DTS mistakenly set its > regulator-min/max-microvolt to 1800000. Correct both to 3300000 > to match the rail name, the PCIe/M.2 power requirement, and the > actual hardware wiring on Orange Pi 5. > I guess a "Fixes" tag is in order here: Fixes: b6bc755d806e ("arm64: dts: rockchip: Add Orange Pi 5") And make sure to Cc: > Signed-off-by: Mykola Kvach The change itself makes sense to me. Reviewed-by: Michael Riesch Best regards, Michael > --- > arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts > index ad6d04793b0a..83b9b6645a1e 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts > @@ -14,8 +14,8 @@ vcc3v3_pcie20: regulator-vcc3v3-pcie20 { > gpios = <&gpio0 RK_PC5 GPIO_ACTIVE_HIGH>; > regulator-name = "vcc3v3_pcie20"; > regulator-boot-on; > - regulator-min-microvolt = <1800000>; > - regulator-max-microvolt = <1800000>; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > startup-delay-us = <50000>; > vin-supply = <&vcc5v0_sys>; > }; _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip