From: Joe Perches <joe@perches.com>
To: Julia Lawall <julia.lawall@lip6.fr>,
Haneen Mohammed <hamohammed.sa@gmail.com>
Cc: linux-rockchip@lists.infradead.org,
greg <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
outreachy-kernel <outreachy-kernel@googlegroups.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [Outreachy kernel] [PATCH] gpu: drm: rockchip: Replace dev_* with DRM_DEV_*
Date: Fri, 15 Sep 2017 00:28:43 -0700 [thread overview]
Message-ID: <1505460523.27581.5.camel@perches.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1709150857490.2287@hadrien>
On Fri, 2017-09-15 at 08:58 +0200, Julia Lawall wrote:
>
> On Fri, 15 Sep 2017, Haneen Mohammed wrote:
>
> > This patch replace instances of dev_info/err/debug with
> > DRM_DEV_INFO/ERROR/WARN respectively inorder to use a drm-formatted
> > specific log messages. Issue corrected with the help of the following
> > Coccinelle script:
[]
> > @@ -935,7 +941,8 @@ static void dw_mipi_dsi_encoder_disable(struct drm_encoder *encoder)
> > return;
> >
> > if (clk_prepare_enable(dsi->pclk)) {
> > - dev_err(dsi->dev, "%s: Failed to enable pclk\n", __func__);
> > + DRM_DEV_ERROR(dsi->dev,
> > + "%s: Failed to enable pclk\n", __func__);
The uses of "%s: " ... , __func__ with DRM_DEV_ERROR
is redundant and should be removed.
> > @@ -967,7 +974,8 @@ static void dw_mipi_dsi_encoder_enable(struct drm_encoder *encoder)
> > return;
> >
> > if (clk_prepare_enable(dsi->pclk)) {
> > - dev_err(dsi->dev, "%s: Failed to enable pclk\n", __func__);
> > + DRM_DEV_ERROR(dsi->dev,
> > + "%s: Failed to enable pclk\n", __func__);
etc...
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-09-15 7:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-15 6:47 [PATCH] gpu: drm: rockchip: Replace dev_* with DRM_DEV_* Haneen Mohammed
2017-09-15 6:58 ` [Outreachy kernel] " Julia Lawall
2017-09-15 7:28 ` Joe Perches [this message]
2017-09-15 7:37 ` Mark yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505460523.27581.5.camel@perches.com \
--to=joe@perches.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=hamohammed.sa@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).