From: "Heiko Stübner" <heiko@sntech.de>
To: Andy Yan <andyshrk@163.com>, Andy Yan <andy.yan@rock-chips.com>
Cc: hjc@rock-chips.com, dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, sebastian.reichel@collabora.com,
kever.yang@rock-chips.com, chris.obbard@collabora.com,
s.hauer@pengutronix.de
Subject: Re: [PATCH v2 04/12] drm/rockchip: vop2: clear afbc en and transform bit for cluster window at linear mode
Date: Tue, 28 Nov 2023 09:30:28 +0100 [thread overview]
Message-ID: <15178289.EVyyLHbfrO@diego> (raw)
In-Reply-To: <ebe46d19-954d-4dbb-82ba-a443058e9f4e@rock-chips.com>
Am Dienstag, 28. November 2023, 09:03:46 CET schrieb Andy Yan:
> Hi Heiko:
>
> On 11/27/23 23:02, Heiko Stübner wrote:
> > Am Mittwoch, 22. November 2023, 13:54:25 CET schrieb Andy Yan:
> >> From: Andy Yan <andy.yan@rock-chips.com>
> >>
> >> The enable bit and transform offset of cluster windows should be
> >> cleared when it work at linear mode, or we may have a iommu fault
> >> issue.
> >>
> >> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> > I guess same here?
> >
> > Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver")
>
>
> I'm not sure if we need a Fixes tag here, in fact this issue never happens on
>
> rk3566/8 , because the cluster windows of rk356x only support afbc format,
>
> they don't have a chance to switch between afbc and linear mode.
>
> Of course, the lack support of linear mode of rk356x cluster windows is a thoughtless
>
> of IC design, if it really support both afbc and linear format, we indeed need this fix.
>
> The situation is the same as patch 03/12.
>
> So I hope follow your advice, if it need a Fixes tag here.
ah ok, thanks for the explanation. Then I guess we don't need a fixes tag
when the rk3568 is not affected by this.
Same for the other patch. If you're re-sending you could add this information
to the commit message though. (existing support for rk3568 only supports
afbc cluster windows and is therefore not affected)
Thanks
Heiko
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2023-11-28 8:30 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 12:53 [PATCH v2 00/12] Add VOP2 support on rk3588 Andy Yan
2023-11-22 12:53 ` [PATCH v2 01/12] drm/rockchip: move output interface related definition to rockchip_drm_drv.h Andy Yan
2023-11-27 14:03 ` Sascha Hauer
2023-11-22 12:54 ` [PATCH v2 02/12] Revert "drm/rockchip: vop2: Use regcache_sync() to fix suspend/resume" Andy Yan
2023-11-27 14:04 ` Sascha Hauer
2023-11-22 12:54 ` [PATCH v2 03/12] drm/rockchip: vop2: set half_block_en bit in all mode Andy Yan
2023-11-27 14:04 ` Sascha Hauer
2023-11-27 15:01 ` Heiko Stübner
2023-11-22 12:54 ` [PATCH v2 04/12] drm/rockchip: vop2: clear afbc en and transform bit for cluster window at linear mode Andy Yan
2023-11-27 14:04 ` Sascha Hauer
2023-11-27 15:02 ` Heiko Stübner
2023-11-28 8:03 ` Andy Yan
2023-11-28 8:30 ` Heiko Stübner [this message]
2023-11-28 9:44 ` Andy Yan
2023-11-22 12:54 ` [PATCH v2 05/12] drm/rockchip: vop2: Set YUV/RGB overlay mode Andy Yan
2023-11-27 14:16 ` Sascha Hauer
2023-11-29 6:52 ` Andy Yan
2023-11-22 12:54 ` [PATCH v2 06/12] drm/rockchip: vop2: rename grf to sys_grf Andy Yan
2023-11-27 14:17 ` Sascha Hauer
2023-11-22 12:55 ` [PATCH v2 07/12] dt-bindings: soc: rockchip: add rk3588 vop/vo syscon Andy Yan
2023-11-22 12:55 ` [PATCH v2 08/12] dt-bindings: display: vop2: Add rk3588 support Andy Yan
2023-11-22 19:07 ` Krzysztof Kozlowski
2023-11-30 12:32 ` Andy Yan
2023-11-22 12:55 ` [PATCH v2 09/12] dt-bindings: soc: vop2: Add more endpoint definition Andy Yan
2023-11-22 19:08 ` Krzysztof Kozlowski
2023-11-22 12:55 ` [PATCH v2 10/12] drm/rockchip: vop2: Add support for rk3588 Andy Yan
2023-11-27 11:19 ` Sascha Hauer
2023-11-29 8:28 ` Andy Yan
2023-11-27 15:29 ` Heiko Stübner
2023-11-28 9:32 ` Andy Yan
2023-11-28 9:44 ` Heiko Stübner
2023-11-28 10:11 ` Andy Yan
2023-11-22 12:56 ` [PATCH v2 11/12] drm/rockchip: vop2: Add debugfs support Andy Yan
2023-11-27 10:13 ` Sascha Hauer
[not found] ` <ea24a638-d10f-4f58-9992-1c80bafdd6d4@rock-chips.com>
2023-11-29 8:52 ` Sascha Hauer
2023-11-29 11:01 ` Andy Yan
2023-11-29 12:59 ` Sascha Hauer
2023-11-30 1:15 ` Andy Yan
2023-11-22 12:56 ` [PATCH v2 12/12] arm64: dts: rockchip: Add vop on rk3588 Andy Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15178289.EVyyLHbfrO@diego \
--to=heiko@sntech.de \
--cc=andy.yan@rock-chips.com \
--cc=andyshrk@163.com \
--cc=chris.obbard@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hjc@rock-chips.com \
--cc=kever.yang@rock-chips.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox