From: "Leonidas P. Papadakos" <papadakospan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Levin Du <djw-Efosm3t9Qi2Pt1CcHtbs0g@public.gmane.org>
Subject: Re: [PATCH] arm64: dts: rockchip: fix rk3328-roc-cc gmac2io tx/rx_delay
Date: Wed, 06 Mar 2019 03:36:59 +0200 [thread overview]
Message-ID: <1551836219.5698.0@gmail.com> (raw)
In-Reply-To: <3120482.od4P9FZq9J@phil>
Στις Κυρ, 3 Μαρ, 2019 at 4:10 ΜΜ, ο/η Heiko Stuebner
<heiko@sntech.de> έγραψε:
> Am Donnerstag, 28. Februar 2019, 23:29:23 CET schrieb Leonidas P.
> Papadakos:
>> The rk3328-roc-cc board exhibits tx stability issues with large
>> packets,
>> as does the rock64 board, which was fixed with this patch
>> https://patchwork.kernel.org/patch/10178969/
>>
>> A similar patch was merged for the rk3328-roc-cc here
>> https://patchwork.kernel.org/patch/10804863/
>> but it doesn't include the tx/rx_delay tweaks, and I find that they
>> help with an issue where large transfers would bring the ethernet
>> link down, causing a link reset regularly.
>>
>> Signed-off-by: Leonidas P. Papadakos <papadakospan@gmail.com>
>
> applied as fix for the 5.1-rc cycle starting in about 2 weeks.
>
> Thanks
> Heiko
>
>
It seems like the delays for the rk3328-roc-cc should be like this:
tx_delay = <0x28>;
rx_delay = <0x16>;
What should I do? Make a new patch? If so, what tree do I base it on?
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2019-03-06 1:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 22:29 [PATCH] arm64: dts: rockchip: fix rk3328-roc-cc gmac2io tx/rx_delay Leonidas P. Papadakos
[not found] ` <20190228222923.30418-1-papadakospan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-03-03 14:10 ` Heiko Stuebner
2019-03-06 1:36 ` Leonidas P. Papadakos [this message]
[not found] ` <1551836219.5698.0-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-03-06 7:43 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1551836219.5698.0@gmail.com \
--to=papadakospan-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=djw-Efosm3t9Qi2Pt1CcHtbs0g@public.gmane.org \
--cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox