From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Leonidas P. Papadakos" Subject: Re: [PATCH v2] arm64: dts: rockchip: fix rk3328-roc-cc gmac2io tx/rx_delay Date: Sat, 09 Mar 2019 01:26:43 +0200 Message-ID: <1552087603.1401.0@gmail.com> References: <20190306223454.2959-1-papadakospan@gmail.com> <24c5ffaa-644d-4623-a635-6842f67efe8a@gmail.com> <1552008447.3271.0@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1552008447.3271.0-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Peter Geis Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Rob Herring , Thomas McKahan , Heiko Stuebner List-Id: linux-rockchip.vger.kernel.org >> When I submitted the patch to fix the TX stability issue, I intended >> to follow up with another patch for delay updates. >> Unfortunately, I was unable to locate a delay that was acceptable, >> as I was never able to get below ~700 retry attempts on the TX side >> in testing. >> >> I am unsure if this is due to manufacturing defects or if I'm >> missing something else. >> It may be worth considering implementing some sort of delay auto >> tuning, similar to the mmc driver. >> Thoughts? > > I feared as much. The delays on the tx side do seem to be more of a > mitigation. > I you have the know-how for it, it would be pretty cool Interesting approach to this by ayufan: https://github.com/ayufan-rock64/linux-mainline-kernel/commit/41eeb7cd789ea7cac0cbf4b35b53055f354da757 I hope he sends it upstream as well