Re: [PATCH v2] arm64: dts: rockchip: fix rk3328-roc-cc gmac2io tx/rx_delay

["Leonidas P. Papadakos" <papadakospan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

> So I discovered the cause of my TX issues, at least on my 
> rk3328-roc-cc.
> The rk3328.dtsi is missing several rgmii tx pull strength values.
> This is causing them to default to 0ma.
> 
> I've pushed them to 12ma, same as the other tx values, and I'm 
> getting 600 mbps tx, with no TX failures.
> 
> I am also going to test his adaptive patch once it's done building.
> 
> Thoughts?
> 
> 
> diff --git a/arch/arm65/boot/dts/rockchip/rk3328-roc-cc.dts 
> b/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts
> index c0519bc5884e..696627bf3331 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts
> @@ -280,6 +280,26 @@
>  			rockchip,pins = <0 RK_PA0 RK_FUNC_GPIO &pcfg_pull_none>;
>  		};
>  	};
> +
> +	gmac-1 {
> +		rgmiim1_pins: rgmiim1-pins {
> +			rockchip,pins =
> +				/* mac_txclk */
> +				<0 RK_PB0 1 &pcfg_pull_none_12ma>,
> +				/* mac_txen */
> +				<0 RK_PB4 1 &pcfg_pull_none_12ma>,
> +				/* mac_clk */
> +				<0 RK_PD0 1 &pcfg_pull_none_12ma>,
> +				/* mac_txd1 */
> +				<0 RK_PC0 1 &pcfg_pull_none_12ma>,
> +				/* mac_txd0 */
> +				<0 RK_PC1 1 &pcfg_pull_none_12ma>,
> +				/* mac_txd3 */
> +				<0 RK_PC7 1 &pcfg_pull_none_12ma>,
> +				/* mac_txd2 */
> +				<0 RK_PC6 1 &pcfg_pull_none_12ma>;
> +		};
> +	};
>  };
> 
>  &sdmmc {
Good find! It seems like they're there in the dtsi, but configured as 
none when it comes to ma. I'll test it