From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Leonidas P. Papadakos" <papadakospan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v2] arm64: dts: rockchip: fix rk3328-roc-cc gmac2io
 tx/rx_delay
Date: Sat, 09 Mar 2019 05:26:30 +0200
Message-ID: <1552101990.1401.3@gmail.com>
References: <20190306223454.2959-1-papadakospan@gmail.com>
 <24c5ffaa-644d-4623-a635-6842f67efe8a@gmail.com>
 <1552008447.3271.0@gmail.com> <1552087603.1401.0@gmail.com>
 <ec810aad-dd04-84e4-bfb0-98b005cf3f03@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
In-Reply-To: <ec810aad-dd04-84e4-bfb0-98b005cf3f03-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-rockchip>,
 <mailto:linux-rockchip-request-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-rockchip/>
List-Post: <mailto:linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
List-Help: <mailto:linux-rockchip-request-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-rockchip>,
 <mailto:linux-rockchip-request-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org?subject=subscribe>
Sender: "Linux-rockchip" <linux-rockchip-bounces-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
To: Peter Geis <pgwipeout-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Thomas McKahan <tonymckahan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
List-Id: linux-rockchip.vger.kernel.org


> So I discovered the cause of my TX issues, at least on my 
> rk3328-roc-cc.
> The rk3328.dtsi is missing several rgmii tx pull strength values.
> This is causing them to default to 0ma.
> 
> I've pushed them to 12ma, same as the other tx values, and I'm 
> getting 600 mbps tx, with no TX failures.
> 
> I am also going to test his adaptive patch once it's done building.
> 
> Thoughts?
> 
> 
> diff --git a/arch/arm65/boot/dts/rockchip/rk3328-roc-cc.dts 
> b/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts
> index c0519bc5884e..696627bf3331 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts
> @@ -280,6 +280,26 @@
>  			rockchip,pins = <0 RK_PA0 RK_FUNC_GPIO &pcfg_pull_none>;
>  		};
>  	};
> +
> +	gmac-1 {
> +		rgmiim1_pins: rgmiim1-pins {
> +			rockchip,pins =
> +				/* mac_txclk */
> +				<0 RK_PB0 1 &pcfg_pull_none_12ma>,
> +				/* mac_txen */
> +				<0 RK_PB4 1 &pcfg_pull_none_12ma>,
> +				/* mac_clk */
> +				<0 RK_PD0 1 &pcfg_pull_none_12ma>,
> +				/* mac_txd1 */
> +				<0 RK_PC0 1 &pcfg_pull_none_12ma>,
> +				/* mac_txd0 */
> +				<0 RK_PC1 1 &pcfg_pull_none_12ma>,
> +				/* mac_txd3 */
> +				<0 RK_PC7 1 &pcfg_pull_none_12ma>,
> +				/* mac_txd2 */
> +				<0 RK_PC6 1 &pcfg_pull_none_12ma>;
> +		};
> +	};
>  };
> 
>  &sdmmc {
Good find! It seems like they're there in the dtsi, but configured as 
none when it comes to ma. I'll test it