Re: [PATCH] arm64: dts: rockchip: qnap-ts433: Simplify network PHY connection

From: Diederik de Haas <didi.debian@cknow.org>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: "Chen-Yu Tsai" <wens@kernel.org>,
	"Jonas Karlman" <jonas@kwiboo.se>,
	linux-rockchip@lists.infradead.org,
	linux-rockchip@lists.infradead.org,
	"Uwe Kleine-König" <ukleinek@debian.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	"Andrew Lunn" <andrew@lunn.ch>
Subject: Re: [PATCH] arm64: dts: rockchip: qnap-ts433: Simplify network PHY connection
Date: Mon, 05 Aug 2024 18:47:41 +0200	[thread overview]
Message-ID: <17406373.mzVfN28SmL@bagend> (raw)
In-Reply-To: <3723411.CpGBqz00pN@diego>

[-- Attachment #1.1: Type: text/plain, Size: 1316 bytes --]

On Monday, 5 August 2024 18:33:52 CEST Heiko Stübner wrote:
> Am Montag, 4. März 2024, 17:47:22 CEST schrieb Diederik de Haas:
> > On Monday, 4 March 2024 16:46:59 CET Jonas Karlman wrote:
> > > Sorry for not getting back to you sooner, but yes I would check with
> > > phy-mode = "rgmii-id". There is also a possible issue with rk gmac
> > > driver in both U-Boot and linux, it always set enable tx/rx delay bit.
> > 
> > > Please, try with following in U-Boot:
> > No worries :)
> > Will try your suggestions soon, but it's probably better to take that
> > discussion somewhere else to not further clutter up this patch/thread.
> 
> did you get somewhere with your testing?

Yeah, none of the patches made a difference:

On zaterdag 9 maart 2024 15:51:50 CEST Diederik de Haas wrote:
> I did the following tests based on 2024.01 on my Q64-B:
> - conditional delay: FAIL
> - grf fix: FAIL
> - conditional delay + grf fix: FAIL
> 
> Then I rebased upon 2024.04-rc4:
> - conditional delay + grf fix: FAIL
> I skipped the other variations, but could do that if that could be useful.

After the 2024.07 release I checked again and it still failed and my 
workaround (partial revert) still worked, so I reported it to the u-boot ML:

https://lore.kernel.org/u-boot/2086393.9F9pDXStbY@bagend/

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip