* [PATCH] arm64: dts: rockchip: rk3588s-rock-5a: Add green power LED
@ 2025-08-20 2:30 kylepzak
2025-08-24 7:07 ` Heiko Stuebner
0 siblings, 1 reply; 2+ messages in thread
From: kylepzak @ 2025-08-20 2:30 UTC (permalink / raw)
To: heiko; +Cc: devicetree, linux-arm-kernel, linux-rockchip, conor+dt, krzk+dt,
robh
The Radxa ROCK 5A board includes a green power LED that is defined in
the vendor device tree but is missing from the upstream kernel DTS file.
This causes the LED to be uncontrollable from the operating system, as no
entry is created for it under /sys/class/leds.
This patch adds the missing node to the leds block, creating a
"green:power" device and allowing the LED to be controlled by the kernel.
Signed-off-by: Kyle Petryszak <kylepzak@projectinitiative.io>
---
arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts
index f894742b1ebe..f70b49d9361a 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts
@@ -52,6 +52,13 @@ leds {
pinctrl-names = "default";
pinctrl-0 = <&io_led>;
+ power-led {
+ color = <LED_COLOR_ID_GREEN>;
+ function = LED_FUNCTION_POWER;
+ gpios = <&gpio3 RK_PC4 GPIO_ACTIVE_HIGH>;
+ linux,default-trigger = "default-on";
+ };
+
io-led {
color = <LED_COLOR_ID_BLUE>;
function = LED_FUNCTION_STATUS;
--
2.49.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: rk3588s-rock-5a: Add green power LED
2025-08-20 2:30 [PATCH] arm64: dts: rockchip: rk3588s-rock-5a: Add green power LED kylepzak
@ 2025-08-24 7:07 ` Heiko Stuebner
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stuebner @ 2025-08-24 7:07 UTC (permalink / raw)
To: kylepzak
Cc: Heiko Stuebner, devicetree, linux-arm-kernel, linux-rockchip,
conor+dt, krzk+dt, robh
On Tue, 19 Aug 2025 21:30:12 -0500, kylepzak@projectinitiative.io wrote:
> The Radxa ROCK 5A board includes a green power LED that is defined in
> the vendor device tree but is missing from the upstream kernel DTS file.
>
> This causes the LED to be uncontrollable from the operating system, as no
> entry is created for it under /sys/class/leds.
>
> This patch adds the missing node to the leds block, creating a
> "green:power" device and allowing the LED to be controlled by the kernel.
>
> [...]
Applied, thanks!
[1/1] arm64: dts: rockchip: rk3588s-rock-5a: Add green power LED
commit: 5487086c4dad869af0eeca0ee24d1ba5fe382b3c
moved the "power-led" node behind the "io-led" node,
please sort nodes alphabetically in future patches :-) .
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-08-24 7:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-20 2:30 [PATCH] arm64: dts: rockchip: rk3588s-rock-5a: Add green power LED kylepzak
2025-08-24 7:07 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).