From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89AFBC982DC for ; Fri, 18 Sep 2026 12:08:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WNMHTrg5SbKGJDypcmzDeFOzIEqR10CYkjyCDJdVhHU=; b=J9KhA0JIdMKDy3 r4ZLG/N9inOFiVSY/hHbiFYsbOJxWmDVlmlFAnQoeRRSQLu3j3omyhq7qjKw4BgoSWUCroiwsUxUq t2sKlfAonXMolqtrFitEQjqnkhCzff900gFAXH0F7IidGDiomUZP6Tm114Rl41NxTh6N/1Zs/OeeN YnBWOVnLDD4di5tW8Nqwm6MVF90hxK2iGZMOCzICBNlINBzFAqbCK7EwtRNRorp2XXGq3xlG0JMRS mPZPu7+XxfwyVmn+dxkVTsoNZXOHiU+iO/1gVxj5rhXw/2ij5pgbVCrkERQFAkK/aAbd3eXjHm5Xz lSQAKvKUyWDpawaD1t3w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7XO9-0000000EKP7-0l2W; Fri, 18 Sep 2026 12:08:21 +0000 Received: from mail-m10313119145.xmail.ntesmail.com ([103.131.191.45]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7XO6-0000000EKNN-0BAY for linux-rockchip@lists.infradead.org; Fri, 18 Sep 2026 12:08:19 +0000 Received: from localhost.localdomain (unknown [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 4e4c12fe4; Fri, 18 Sep 2026 20:08:13 +0800 (GMT+08:00) From: Shawn Lin To: Ulf Hansson , Heiko Stuebner Cc: linux-pm@vger.kernel.org, linux-rockchip@lists.infradead.org, Shawn Lin Subject: [PATCH 3/4] pmdomain: rockchip: don't ignore clock lookup errors on attach Date: Fri, 18 Sep 2026 20:07:37 +0800 Message-Id: <1789733258-10133-4-git-send-email-shawn.lin@rock-chips.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1789733258-10133-1-git-send-email-shawn.lin@rock-chips.com> References: <1789733258-10133-1-git-send-email-shawn.lin@rock-chips.com> X-HM-Tid: 0aa0b46ace9403a4kunm5c34220f164153 X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1kYFggdWUFKV1ktWUFJV1kPCRoVCBIfWUFZGkJLHlYeGBpNQkNIHU 5LSU5WFRQJFhoXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0 tIVUpLSU9PT0hVSktLVUpCS0tZBg++ DKIM-Signature: a=rsa-sha256; b=NEbq007xdkUOukjNBFMQ7SfxdWr1SQl/aM0jmDJGNj9k1KyYaPZjSXmVEcOd5BoW6qYKSELwgW6hZE1GO/9/vCECrcTW1rOWgEYRzi/mb4g2Cw6cspXqc1pImzOr1dZIHjxUUIvdRDKYEZEpNKO2Yd7utBZY/QV638P+ah4KjLE=; s=default; c=relaxed/relaxed; d=rock-chips.com; v=1; bh=S0oqhM1xlrebsyl35WHqeNuFrQM79UrsFwqvZTMxkDE=; h=date:mime-version:subject:message-id:from; X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260918_050818_363376_CCDA9988 X-CRM114-Status: GOOD ( 12.34 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org rockchip_pd_attach_dev() treated every of_clk_get() error as the end of the clock list, so a clock that exists but is not available yet (e.g. -EPROBE_DEFER) was silently skipped and the device ended up without pm_clk management. Only -ENOENT means there are no more clocks. Fixes: 7c696693a4f5 ("soc: rockchip: power-domain: Add power domain driver") Signed-off-by: Shawn Lin --- drivers/pmdomain/rockchip/pm-domains.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/pmdomain/rockchip/pm-domains.c b/drivers/pmdomain/rockchip/pm-domains.c index b6b099b..e193f97 100644 --- a/drivers/pmdomain/rockchip/pm-domains.c +++ b/drivers/pmdomain/rockchip/pm-domains.c @@ -759,7 +759,19 @@ static int rockchip_pd_attach_dev(struct generic_pm_domain *genpd, } i = 0; - while ((clk = of_clk_get(dev->of_node, i++)) && !IS_ERR(clk)) { + while (1) { + clk = of_clk_get(dev->of_node, i++); + if (IS_ERR(clk)) { + error = PTR_ERR(clk); + if (error == -ENOENT) + break; + + dev_err(dev, "failed to get clock %d: %d\n", i - 1, + error); + pm_clk_destroy(dev); + return error; + } + dev_dbg(dev, "adding clock '%pC' to list of PM clocks\n", clk); error = pm_clk_add_clk(dev, clk); if (error) { -- 2.7.4 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip