From: Heiko Stuebner <heiko@sntech.de>
To: Rob Herring <robh@kernel.org>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org,
Grant Likely <glikely@secretlab.ca>,
Kumar Gala <kumar.gala@linaro.org>,
Frank Rowand <frowand.list@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
Linus Walleij <linus.walleij@linaro.org>,
Olof Johansson <olof@lixom.net>, Arnd Bergmann <arnd@arndb.de>,
Mark Brown <broonie@kernel.org>, Tom Rini <trini@konsulko.com>,
Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Jonathan Cameron <jic23@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 28/36] dt-bindings: arm: Convert Rockchip board/soc bindings to json-schema
Date: Mon, 08 Oct 2018 11:45:19 +0200 [thread overview]
Message-ID: <1857752.ZLvpeyYpZr@phil> (raw)
In-Reply-To: <20181005165848.3474-29-robh@kernel.org>
Hi Rob,
either I'm misunderstanding that, or something did go a bit wrong during
the conversion, as pointed out below:
Am Freitag, 5. Oktober 2018, 18:58:40 CEST schrieb Rob Herring:
> Convert Rockchip SoC bindings to DT schema format using json-schema.
>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: devicetree@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-rockchip@lists.infradead.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../devicetree/bindings/arm/rockchip.txt | 220 ----------------
> .../devicetree/bindings/arm/rockchip.yaml | 242 ++++++++++++++++++
> 2 files changed, 242 insertions(+), 220 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/arm/rockchip.txt
> create mode 100644 Documentation/devicetree/bindings/arm/rockchip.yaml
>
> +properties:
> + $nodename:
> + const: '/'
> + compatible:
> + oneOf:
> + - items:
> + - enum:
> + - amarula,vyasa-rk3288
> + - asus,rk3288-tinker
> + - radxa,rock2-square
> + - chipspark,popmetal-rk3288
> + - netxeon,r89
> + - firefly,firefly-rk3288
> + - firefly,firefly-rk3288-beta
> + - firefly,firefly-rk3288-reload
> + - mqmaker,miqi
> + - rockchip,rk3288-fennec
> + - const: rockchip,rk3288
These are very much distinct boards, so shouldn't they also get
individual entries including their existing description like the phytec
or google boards below?
Similarly why is it an enum for those, while the Google boards get a
const for each compatible string?
Most non-google boards below also lost their description and where lumped
together into combined entries. Was that intentional?
Thanks
Heiko
> +
> + - description: Phytec phyCORE-RK3288 Rapid Development Kit
> + items:
> + - const: phytec,rk3288-pcm-947
> + - const: phytec,rk3288-phycore-som
> + - const: rockchip,rk3288
> +
> + - description: Google Mickey (Asus Chromebit CS10)
> + items:
> + - const: google,veyron-mickey-rev8
> + - const: google,veyron-mickey-rev7
> + - const: google,veyron-mickey-rev6
> + - const: google,veyron-mickey-rev5
> + - const: google,veyron-mickey-rev4
> + - const: google,veyron-mickey-rev3
> + - const: google,veyron-mickey-rev2
> + - const: google,veyron-mickey-rev1
> + - const: google,veyron-mickey-rev0
> + - const: google,veyron-mickey
> + - const: google,veyron
> + - const: rockchip,rk3288
> +
> + - description: Google Minnie (Asus Chromebook Flip C100P)
> + items:
> + - const: google,veyron-minnie-rev4
> + - const: google,veyron-minnie-rev3
> + - const: google,veyron-minnie-rev2
> + - const: google,veyron-minnie-rev1
> + - const: google,veyron-minnie-rev0
> + - const: google,veyron-minnie
> + - const: google,veyron
> + - const: rockchip,rk3288
> +
> + - description: Google Pinky (dev-board)
> + items:
> + - const: google,veyron-pinky-rev2
> + - const: google,veyron-pinky
> + - const: google,veyron
> + - const: rockchip,rk3288
> +
> + - description: Google Speedy (Asus C201 Chromebook)
> + items:
> + - const: google,veyron-speedy-rev9
> + - const: google,veyron-speedy-rev8
> + - const: google,veyron-speedy-rev7
> + - const: google,veyron-speedy-rev6
> + - const: google,veyron-speedy-rev5
> + - const: google,veyron-speedy-rev4
> + - const: google,veyron-speedy-rev3
> + - const: google,veyron-speedy-rev2
> + - const: google,veyron-speedy
> + - const: google,veyron
> + - const: rockchip,rk3288
> +
> + - description: Google Jaq (Haier Chromebook 11 and more)
> + items:
> + - const: google,veyron-jaq-rev5
> + - const: google,veyron-jaq-rev4
> + - const: google,veyron-jaq-rev3
> + - const: google,veyron-jaq-rev2
> + - const: google,veyron-jaq-rev1
> + - const: google,veyron-jaq
> + - const: google,veyron
> + - const: rockchip,rk3288
> +
> + - description: Google Jerry (Hisense Chromebook C11 and more)
> + items:
> + - const: google,veyron-jerry-rev7
> + - const: google,veyron-jerry-rev6
> + - const: google,veyron-jerry-rev5
> + - const: google,veyron-jerry-rev4
> + - const: google,veyron-jerry-rev3
> + - const: google,veyron-jerry
> + - const: google,veyron
> + - const: rockchip,rk3288
> +
> + - description: Google Brain (dev-board)
> + items:
> + - const: google,veyron-brain-rev0
> + - const: google,veyron-brain
> + - const: google,veyron
> + - const: rockchip,rk3288
> +
> + - items:
> + - enum:
> + - rockchip,kylin-rk3036
> + - const: rockchip,rk3036
> +
> + - items:
> + - enum:
> + - haoyu,marsboard-rk3066
> + - mundoreader,bq-curie2
> + - chipspark,rayeager-px2
> + - rikomagic,mk80
> + - const: rockchip,rk3066a
> +
> + - items:
> + - enum:
> + - radxa,rock
> + - const: rockchip,rk3188
> +
> + - items:
> + - const: rockchip,px3-evb
> + - const: rockchip,px3
> + - const: rockchip,rk3188
> +
> + - items:
> + - enum:
> + - firefly,roc-rk3328-cc
> + - pine64,rock64
> + - rockchip,rk3328-evb
> + - const: rockchip,rk3328
> +
> + - items:
> + - enum:
> + - geekbuying,geekbox
> + - rockchip,rk3368-evb-act8846
> + - rockchip,r88
> + - tsd,rk3368-uq7-haikou
> + - tronsmart,orion-r68-meta
> + - const: rockchip,rk3368
> +
> + - items:
> + - enum:
> + - geekbuying,geekbox
> + - rockchip,rk3368-evb-act8846
> + - rockchip,r88
> + - tsd,rk3368-uq7-haikou
> + - tronsmart,orion-r68-meta
> + - const: rockchip,rk3368
> +
> + - items:
> + - const: rockchip,px5-evb
> + - const: rockchip,px5
> + - const: rockchip,rk3368
> +
> + - items:
> + - enum:
> + - firefly,firefly-rk3399
> + - rockchip,rk3399-evb
> + - rockchip,rk3399-sapphire
> + - rockchip,rk3399-sapphire-excavator
> + - tsd,rk3399-q7-haikou
> + - vamrs,ficus
> + - const: rockchip,rk3399
> +
> + - description: Google Bob (Asus Chromebook Flip C101PA)
> + items:
> + - const: google,bob-rev13
> + - const: google,bob-rev12
> + - const: google,bob-rev11
> + - const: google,bob-rev10
> + - const: google,bob-rev9
> + - const: google,bob-rev8
> + - const: google,bob-rev7
> + - const: google,bob-rev6
> + - const: google,bob-rev5
> + - const: google,bob-rev4
> + - const: google,bob
> + - const: google,gru
> + - const: rockchip,rk3399
> +
> + - description: Google Gru (dev-board)
> + items:
> + - const: google,gru-rev15
> + - const: google,gru-rev14
> + - const: google,gru-rev13
> + - const: google,gru-rev12
> + - const: google,gru-rev11
> + - const: google,gru-rev10
> + - const: google,gru-rev9
> + - const: google,gru-rev8
> + - const: google,gru-rev7
> + - const: google,gru-rev6
> + - const: google,gru-rev5
> + - const: google,gru-rev4
> + - const: google,gru-rev3
> + - const: google,gru-rev2
> + - const: google,gru
> + - const: rockchip,rk3399
> +
> + - description: Google Kevin (Samsung Chromebook Plus)
> + items:
> + - const: google,kevin-rev15
> + - const: google,kevin-rev14
> + - const: google,kevin-rev13
> + - const: google,kevin-rev12
> + - const: google,kevin-rev11
> + - const: google,kevin-rev10
> + - const: google,kevin-rev9
> + - const: google,kevin-rev8
> + - const: google,kevin-rev7
> + - const: google,kevin-rev6
> + - const: google,kevin
> + - const: google,gru
> + - const: rockchip,rk3399
> +
> + - items:
> + - enum:
> + - rockchip,rv1108-evb
> + - const: rockchip,rv1108
> +
> + - items:
> + - enum:
> + - rockchip,rk3228-evb
> + - const: rockchip,rk3228
> +
> + - items:
> + - enum:
> + - rockchip,rk3229-evb
> + - const: rockchip,rk3229
> +...
>
next prev parent reply other threads:[~2018-10-08 9:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181005165848.3474-1-robh@kernel.org>
2018-10-05 16:58 ` [PATCH 28/36] dt-bindings: arm: Convert Rockchip board/soc bindings to json-schema Rob Herring
2018-10-08 9:45 ` Heiko Stuebner [this message]
2018-10-08 13:46 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1857752.ZLvpeyYpZr@phil \
--to=heiko@sntech.de \
--cc=arnd@arndb.de \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=geert@linux-m68k.org \
--cc=glikely@secretlab.ca \
--cc=jic23@kernel.org \
--cc=kumar.gala@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=olof@lixom.net \
--cc=pantelis.antoniou@konsulko.com \
--cc=robh@kernel.org \
--cc=trini@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox