From: Heiko Stuebner <heiko@sntech.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH 30/40] soc/rockchip: io-domain: Convert to platform remove callback returning void
Date: Mon, 02 Oct 2023 00:58:30 +0200 [thread overview]
Message-ID: <1865054.tdWV9SEqCh@phil> (raw)
In-Reply-To: <20230925095532.1984344-31-u.kleine-koenig@pengutronix.de>
Am Montag, 25. September 2023, 11:55:21 CEST schrieb Uwe Kleine-König:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new() which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
applied for 6.7
Thanks
Heiko
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2023-10-01 22:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 9:54 [PATCH 00/40] soc: Convert to platform remove callback returning void Uwe Kleine-König
2023-09-25 9:55 ` [PATCH 30/40] soc/rockchip: io-domain: " Uwe Kleine-König
2023-10-01 22:58 ` Heiko Stuebner [this message]
2023-09-25 9:58 ` [PATCH 00/40] soc: " Konrad Dybcio
2023-09-27 2:25 ` Joel Stanley
2023-09-27 8:43 ` Arnd Bergmann
2023-09-27 23:01 ` Bjorn Andersson
2023-09-28 6:14 ` Uwe Kleine-König
2023-10-14 21:59 ` [GIT PULL] Convert drivers/soc to struct platform_driver::remove_new() Uwe Kleine-König
2023-10-02 14:13 ` (subset) [PATCH 00/40] soc: Convert to platform remove callback returning void Nishanth Menon
2023-10-03 1:10 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1865054.tdWV9SEqCh@phil \
--to=heiko@sntech.de \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).