From: "Heiko Stübner" <heiko@sntech.de>
To: Detlev Casanova <detlev.casanova@collabora.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Nicolas Dufresne <nicolas.dufresne@collabora.com>
Cc: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Nicolas Dufresne <nicolas.dufresne@collabora.com>
Subject: Re: [PATCH v2] media: rkvdec: Remove redundant
Date: Mon, 11 Aug 2025 16:37:27 +0200 [thread overview]
Message-ID: <1894144.QZUTf85G27@diego> (raw)
In-Reply-To: <20250811-rkvdec-redundant-pm-rebase-v2-1-90c47213fbbe@collabora.com>
Am Montag, 11. August 2025, 16:03:45 Mitteleuropäische Sommerzeit schrieb Nicolas Dufresne:
> From: Sakari Ailus <sakari.ailus@linux.intel.com>
>
> pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(),
> pm_runtime_autosuspend() and pm_request_autosuspend() now include a call
> to pm_runtime_mark_last_busy(). Remove the now-reduntant explicit call to
> pm_runtime_mark_last_busy().
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
> Signed-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
verifíed the (new) definition of pm_runtime_put_autosuspend()
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
But the subject could use some work, I only got
"[PATCH v2] media: rkvdec: Remove redundant"
so maybe make that
"media: rkvdec: Remove redundant pm_runtime_mark_last_busy"
Heiko
> ---
> Changes since V1:
> - Re-applied since the driver have been moved out of staging
> ---
> drivers/media/platform/rockchip/rkvdec/rkvdec.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/platform/rockchip/rkvdec/rkvdec.c b/drivers/media/platform/rockchip/rkvdec/rkvdec.c
> index d707088ec0dc1f6a18b2d168ebdf20b443f2240e..445f7c92eee34f7d6f885bb519d9eb24313da548 100644
> --- a/drivers/media/platform/rockchip/rkvdec/rkvdec.c
> +++ b/drivers/media/platform/rockchip/rkvdec/rkvdec.c
> @@ -765,7 +765,6 @@ static void rkvdec_job_finish(struct rkvdec_ctx *ctx,
> {
> struct rkvdec_dev *rkvdec = ctx->dev;
>
> - pm_runtime_mark_last_busy(rkvdec->dev);
> pm_runtime_put_autosuspend(rkvdec->dev);
> rkvdec_job_finish_no_pm(ctx, result);
> }
>
> ---
> base-commit: 8f5ae30d69d7543eee0d70083daf4de8fe15d585
> change-id: 20250811-rkvdec-redundant-pm-rebase-ed9b885eeadd
>
> Best regards,
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2025-08-11 16:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 14:03 [PATCH v2] media: rkvdec: Remove redundant Nicolas Dufresne
2025-08-11 14:30 ` Markus Elfring
2025-08-11 14:37 ` Heiko Stübner [this message]
2025-08-11 14:48 ` Nicolas Dufresne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1894144.QZUTf85G27@diego \
--to=heiko@sntech.de \
--cc=detlev.casanova@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=nicolas.dufresne@collabora.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).