From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Frank Wunderlich <frank-w@public-files.de>
Cc: Frank Wunderlich <linux@fw-web.de>,
devicetree@vger.kernel.org,
Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Rob Herring <robh+dt@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Gregory Clement <gregory.clement@bootlin.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Heiko Stuebner <heiko@sntech.de>,
Peter Geis <pgwipeout@gmail.com>,
Michael Riesch <michael.riesch@wolfvision.net>,
Hans de Goede <hdegoede@redhat.com>, Jens Axboe <axboe@kernel.dk>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: Aw: Re: Re: [PATCH v5 1/5] dt-bindings: ata: ahci-platform: Convert DT bindings to yaml
Date: Sun, 6 Mar 2022 12:15:39 +0100 [thread overview]
Message-ID: <18f4dc19-b8a4-015e-48c8-923326cc7932@canonical.com> (raw)
In-Reply-To: <trinity-d42352e1-d778-40dd-9464-90a145653f74-1646563315484@3c-app-gmx-bs46>
On 06/03/2022 11:41, Frank Wunderlich wrote:
>> Gesendet: Sonntag, 06. März 2022 um 11:27 Uhr
>> Von: "Krzysztof Kozlowski" <krzysztof.kozlowski@canonical.com>
>>> add compatibles used together with generic-ahci
>>> - marvell,berlin2-ahci
>>
>> This is fine, just mention it in commit msg.
>>
>>> - qcom,apq8064-ahci
>>> - qcom,ipq806x-ahci
>>
>> These you need to consult with qcom-sata.txt. This could be a following
>> commit which will integrate qcom-sata.txt and remove it.
>
> this depends on Robs opinion
Then maybe precise the question for Rob...
>
>> Either you have
>> binding document for all devices or you create a common part, like for UFS:
>> https://lore.kernel.org/linux-devicetree/20220222145854.358646-1-krzysztof.kozlowski@canonical.com/
>> https://github.com/krzk/linux/commits/n/dt-bindings-ufs-v2
>>
>> The choice depends more or less on complexity of bindings, IOW, how big
>> and complicated bindings would be if you combine everything to one YAML.
>>
>> In the case of UFS, the devices differ - by clocks, resets, phys and
>> sometimes supplies. Therefore it easier to have one common shared part
>> and several device bindings.
>>
>> AHCI looks more consistent - except that Qualcomm - so maybe better to
>> have one document.
>>
>>> increase reg-count to 2 (used in omap5-l4.dtsi)
>>> increase clock-count to 5 (used in qcom-apq8064.dtsi)
>>
>> This would need allOf+if.
>
> if i get ok from rob i add only the berlin-compatible and skip the qcom+reg/clock-change in the first applied version. Adding the allOf/if (and making it right) will only delay the sata-binding/dts-change.
I don't get what is the problem with delaying this patch for the time
needed to make the bindings correct? Especially that alternative is to
add bindings document which soon will need to be modified, e.g. split
into common part. Is there a particular hurry with these bindings
conversion?
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2022-03-06 11:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-05 11:26 [PATCH v5 0/5] Add sata nodes to rk356x Frank Wunderlich
2022-03-05 11:26 ` [PATCH v5 1/5] dt-bindings: ata: ahci-platform: Convert DT bindings to yaml Frank Wunderlich
2022-03-05 17:43 ` Krzysztof Kozlowski
2022-03-06 9:47 ` Aw: " Frank Wunderlich
2022-03-06 10:27 ` Krzysztof Kozlowski
2022-03-06 10:41 ` Aw: " Frank Wunderlich
2022-03-06 11:15 ` Krzysztof Kozlowski [this message]
2022-03-06 11:46 ` Aw: " Frank Wunderlich
2022-03-06 11:55 ` Krzysztof Kozlowski
2022-03-07 22:05 ` Aw: " Rob Herring
2022-03-05 11:26 ` [PATCH v5 2/5] arm64: dts: marvell: fix anyOf conditional failed Frank Wunderlich
2022-03-05 11:26 ` [PATCH v5 3/5] dt-bindings: ata: ahci-platform: Add power-domains property Frank Wunderlich
2022-03-05 11:26 ` [PATCH v5 4/5] dt-bindings: ata: ahci-platform: Add rk3568-dwc3-ahci compatible Frank Wunderlich
2022-03-05 17:43 ` Krzysztof Kozlowski
2022-03-05 11:26 ` [PATCH v5 5/5] arm64: dts: rockchip: Add sata nodes to rk356x Frank Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18f4dc19-b8a4-015e-48c8-923326cc7932@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=andrew@lunn.ch \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@opensource.wdc.com \
--cc=devicetree@vger.kernel.org \
--cc=frank-w@public-files.de \
--cc=gregory.clement@bootlin.com \
--cc=hdegoede@redhat.com \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=linux@fw-web.de \
--cc=michael.riesch@wolfvision.net \
--cc=pgwipeout@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox