From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [PATCH] clk: rockchip: validity should be checked prior to clock rate change Date: Tue, 08 Nov 2016 14:26:54 +0100 Message-ID: <1924809.LJTn50YVYo@diego> References: <1478596214-761-1-git-send-email-zhangqing@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1478596214-761-1-git-send-email-zhangqing-TNX95d0MmH7DzftRWevZcw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Elaine Zhang Cc: huangtao-TNX95d0MmH7DzftRWevZcw@public.gmane.org, xf-TNX95d0MmH7DzftRWevZcw@public.gmane.org, mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org, sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, rocky.hao-TNX95d0MmH7DzftRWevZcw@public.gmane.org, jay.xu-TNX95d0MmH7DzftRWevZcw@public.gmane.org, xxx-TNX95d0MmH7DzftRWevZcw@public.gmane.org List-Id: linux-rockchip.vger.kernel.org Hi Elaine, Am Dienstag, 8. November 2016, 17:10:14 schrieb Elaine Zhang: > If validity is not checked prior to clock rate change, clk_set_rate( > cpu_clk, unsupported_rate) will return success, but the real clock rate > change operation is prohibited in post clock change event. Alough post > clock change event will report error due to unsupported clock rate is > set, but this error message is ignored by clock framework. > > Signed-off-by: Elaine Zhang > Signed-off-by: Rocky Hao looks good and thanks for catching this. Just a bureaucracy-question regarding the Signed-off-by lines, before I can apply the patch as I don't really know how Rocky fits into the picture. I.e. was he the original patch author (the we should change the from) or a reviewer/tester for the fixed issue? Thanks Heiko