From: Junhao Xie <bigfoot@classfun.cn>
To: Chukun Pan <amadeus@jmu.edu.cn>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org,
dsimic@manjaro.org, heiko@sntech.de, jonas@kwiboo.se,
krzk+dt@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
Junhao Xie <bigfoot@classfun.cn>
Subject: Re: [PATCH v3 3/3] arm64: dts: rockchip: add dts for Ariaboard Photonicat RK3568
Date: Thu, 12 Sep 2024 21:53:42 +0800 [thread overview]
Message-ID: <1a7d017a-8317-462b-8698-03cc7099a74f@classfun.cn> (raw)
In-Reply-To: <20240912023018.23986-1-amadeus@jmu.edu.cn>
On 2024/9/12 10:30, Chukun Pan wrote:
> Hi Junhao,
>
>> ...
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts
>> ...
>
>> + rfkill-modem {
>> + compatible = "rfkill-gpio";
>> + label = "M.2 USB Modem";
>> + radio-type = "wwan";
>> + reset-gpios = <&gpio0 RK_PB0 GPIO_ACTIVE_LOW>;
>> + shutdown-gpios = <&gpio4 RK_PC4 GPIO_ACTIVE_HIGH>;
>> + };
>
> gpio0 RK_PB0 conflicts with xin32k, please add:
>
> &xin32k {
> pinctrl-names = "default";
> pinctrl-0 = <&clk32k_out1>;
> };
I added it and it currently works fine
>
>> + vccin_5v: regulator-5v0-vcc-in {
>> + vcc_sysin: regulator-5v0-vcc-sysin {
>> + vcc_syson: regulator-5v0-vcc-syson {
>> + vcc5v0_usb30_otg0: regulator-5v0-vcc-usb-host {
>
> obviously (
I seem to have misunderstood the rules in dt-bindings before.
The following looks better:
vcc5v0_usb30_otg0: regulator-vcc5v0-usb30-otg0 {
vccin_5v: regulator-vccin-5v {
vcc_sysin: regulator-vcc-sysin {
vcc_syson: regulator-vcc-syson {
>
Thanks for your review, I will fix all problems in next version!
Best regards,
Junhao
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2024-09-12 13:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 12:28 [PATCH v3 0/3] Add support for Ariaboard Photonicat RK3568 Junhao Xie
2024-09-11 12:28 ` [PATCH v3 1/3] dt-bindings: vendor-prefixes: Add prefix for Ariaboard Junhao Xie
2024-09-11 12:28 ` [PATCH v3 2/3] dt-bindings: arm: rockchip: Add Ariaboard Photonicat RK3568 Junhao Xie
2024-09-11 12:28 ` [PATCH v3 3/3] arm64: dts: rockchip: add dts for " Junhao Xie
2024-09-12 2:30 ` Chukun Pan
2024-09-12 13:53 ` Junhao Xie [this message]
2024-09-18 2:20 ` Chukun Pan
2024-09-21 12:37 ` Junhao Xie
2024-09-11 13:50 ` [PATCH v3 0/3] Add support " Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a7d017a-8317-462b-8698-03cc7099a74f@classfun.cn \
--to=bigfoot@classfun.cn \
--cc=amadeus@jmu.edu.cn \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dsimic@manjaro.org \
--cc=heiko@sntech.de \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox