Re:Re: [PATCH v15 07/13] drm/rockchip: vop2: Register the primary plane and overlay plane separately

["Andy Yan" <andyshrk@163.com>]

Hi Heiko,

At 2025-03-03 02:57:50, "Heiko Stübner" <heiko@sntech.de> wrote:
>Hi Andy,
>
>Am Dienstag, 18. Februar 2025, 12:27:34 MEZ schrieb Andy Yan:
>> From: Andy Yan <andy.yan@rock-chips.com>
>> 
>> In the upcoming VOP of rk3576, a Window cannot attach to all Video Ports,
>> so make sure all VP find it's suitable primary plane, then register the
>> remain windows as overlay plane will make code easier.
>> 
>> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
>> Tested-by: Michael Riesch <michael.riesch@wolfvision.net> # on RK3568
>> Tested-by: Detlev Casanova <detlev.casanova@collabora.com>
>> 
>> ---
>
>patches 7-9 look good to go, but ...
>
>this needs a rebase to adapt to
>"drm/rockchip: vop2: Consistently use dev_err_probe()" [0]
>
>[0] https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/b06d1ef3355571383cdb463cf0195b7a02efdfbf


Thank you.
I sent V16 with the remaining patches rebased on drm-misc-next, and fix the style issues.


>
>
>> -		if (win->type == DRM_PLANE_TYPE_PRIMARY) {
>> -			vp = find_vp_without_primary(vop2);
>> -			if (vp) {
>> +			if (vop2_is_mirror_win(win))
>> +				continue;
>> +
>> +			if (win->type == DRM_PLANE_TYPE_PRIMARY) {
>>  				possible_crtcs = BIT(nvp);
>>  				vp->primary_plane = win;
>> +				ret = vop2_plane_init(vop2, win, possible_crtcs);
>> +				if (ret) {
>> +					drm_err(vop2->drm, "failed to init primary plane %s: %d\n",
>> +						win->data->name, ret);
>
>should also use dev_err_probe
>
>
>Heiko
>
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip