From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Lin Subject: Re: [PATCH] PCI: rockchip: fix bitwise operations on status and ROCKCHIP_PCIE_EP_CMD_STATUS_IS Date: Mon, 15 Apr 2019 09:46:54 +0800 Message-ID: <1df4816e-8d16-e894-e99e-ee16cd1c4cb8@rock-chips.com> References: <20190330150910.9389-1-colin.king@canonical.com> <20190412095125.GB8113@red-moon> Mime-Version: 1.0 Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190412095125.GB8113@red-moon> Sender: linux-kernel-owner@vger.kernel.org To: Lorenzo Pieralisi , Colin King Cc: shawn.lin@rock-chips.com, Bjorn Helgaas , Heiko Stuebner , linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-rockchip.vger.kernel.org On 2019/4/12 17:51, Lorenzo Pieralisi wrote: > On Sat, Mar 30, 2019 at 03:09:10PM +0000, Colin King wrote: >> From: Colin Ian King >> >> Currently the bitwise operations on the u16 variable 'status' with >> the setting ROCKCHIP_PCIE_EP_CMD_STATUS_IS are incorrect because >> ROCKCHIP_PCIE_EP_CMD_STATUS_IS is 1UL<<19 which is wider than the >> u16 variable. Fix this by making status a u32. (Not tested). >> >> Fixes: cf590b078391 ("PCI: rockchip: Add EP driver for Rockchip PCIe controller") >> Signed-off-by: Colin Ian King >> --- >> drivers/pci/controller/pcie-rockchip-ep.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Shawn, > > I need your ACK on this patch, thanks. Acked-by: Shawn Lin > > Lorenzo > >> diff --git a/drivers/pci/controller/pcie-rockchip-ep.c b/drivers/pci/controller/pcie-rockchip-ep.c >> index a5d799e2dff2..d743b0a48988 100644 >> --- a/drivers/pci/controller/pcie-rockchip-ep.c >> +++ b/drivers/pci/controller/pcie-rockchip-ep.c >> @@ -350,7 +350,7 @@ static void rockchip_pcie_ep_assert_intx(struct rockchip_pcie_ep *ep, u8 fn, >> struct rockchip_pcie *rockchip = &ep->rockchip; >> u32 r = ep->max_regions - 1; >> u32 offset; >> - u16 status; >> + u32 status; >> u8 msg_code; >> >> if (unlikely(ep->irq_pci_addr != ROCKCHIP_PCIE_EP_PCI_LEGACY_IRQ_ADDR || >> -- >> 2.20.1 >> > > >