Re: [PATCH 3/5] arm64: dts: rockchip: Fix mic-in-differential usage on rk3568-rock-3a

From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
To: Jonas Karlman <jonas@kwiboo.se>, Lee Jones <lee@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>,
	Chris Zhong <zyw@rock-chips.com>,
	Zhang Qing <zhangqing@rock-chips.com>,
	Chris Morgan <macromorgan@hotmail.com>,
	Furkan Kardame <f.kardame@manjaro.org>,
	Michael Riesch <michael.riesch@wolfvision.net>
Cc: kernel@collabora.com, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] arm64: dts: rockchip: Fix mic-in-differential usage on rk3568-rock-3a
Date: Fri, 21 Jun 2024 04:23:41 +0300	[thread overview]
Message-ID: <1fce65a2-b752-4bab-84e5-314b60d682f0@collabora.com> (raw)
In-Reply-To: <4015ded1-5ec4-4374-982e-9c7f23b43884@collabora.com>

On 6/19/24 3:56 PM, Cristian Ciocaltea wrote:
> Hi Jonas,
> 
> On 6/19/24 3:22 PM, Jonas Karlman wrote:
>> Hi Cristian,
>>
>> On 2024-06-19 13:23, Cristian Ciocaltea wrote:
>>> The 'mic-in-differential' DT property supported by the RK809/RK817 audio
>>> codec driver is actually valid if prefixed with 'rockchip,':
>>>
>>>   DTC_CHK arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dtb
>>>   rk3568-rock-3a.dtb: pmic@20: codec: 'mic-in-differential' does not match any of the regexes: 'pinctrl-[0-9]+'
>>> 	from schema $id: http://devicetree.org/schemas/mfd/rockchip,rk809.yaml#
>>>
>>> Make use of the correct property name.
>>>
>>> Fixes: a84ffd2ef1ff ("arm64: dts: rockchip: Fix mic-in-differential usage on rock-3a")
>>> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
>>> ---
>>>  arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
>>> index ebdedea15ad1..0b54dfe92d6e 100644
>>> --- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
>>> +++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
>>> @@ -533,7 +533,7 @@ regulator-state-mem {
>>>  		};
>>>  
>>>  		codec {
>>> -			mic-in-differential;
>>> +			rockchip,mic-in-differential;
>>
>> If I understand the schematics correctly, only one wire is connected so
>> this board cannot really use differential signaling, and this should
>> probably instead be dropped.
> 
> Thanks for pointing this out, I will drop it in v2.

I've also checked the schematics which indicate the PMIC RK809 CODEC
receives both MIC1_INN and MIC1_INP signals; the former comes from the
Jack input, while the latter is generated by the SLM42Q3AT MEMS Microphone.

However, I'm not sure the Mic presence on the board is dependent on the
HW revision - on REV V1.3 the "NC_" prefix under U24 component label
suggests it is not connected.  So maybe we should keep the property?!

Cristian

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip